Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2513983002:
[ObjC ARC] Converts ios/chrome/browser/sync/sessions:sessions to ARC.Automatically generated ARCM… (Closed)
|
Created:
4 years, 1 month ago by stkhapugin Modified:
4 years ago Reviewers:
sdefresne CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sync-reviews_chromium.org, sdefresne+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[ObjC ARC] Converts ios/chrome/browser/sync/sessions:sessions to ARC.
Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
Patch Set 1 #
Total comments: 2
Messages
Total messages: 25 (14 generated)
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
stkhapugin@chromium.org changed reviewers: + sdefresne@chromium.org
PTAL. Passes downstream tests.
lgtm https://codereview.chromium.org/2513983002/diff/1/ios/chrome/browser/sync/ses... File ios/chrome/browser/sync/sessions/ios_chrome_local_session_event_router.mm (right): https://codereview.chromium.org/2513983002/diff/1/ios/chrome/browser/sync/ses... ios/chrome/browser/sync/sessions/ios_chrome_local_session_event_router.mm:1: // Copyright 2015 The Chromium Authors. All rights reserved. Can this file be renamed to ios_chrome_local_session_event_router.cc?
Thanks! 🎉 https://codereview.chromium.org/2513983002/diff/1/ios/chrome/browser/sync/ses... File ios/chrome/browser/sync/sessions/ios_chrome_local_session_event_router.mm (right): https://codereview.chromium.org/2513983002/diff/1/ios/chrome/browser/sync/ses... ios/chrome/browser/sync/sessions/ios_chrome_local_session_event_router.mm:1: // Copyright 2015 The Chromium Authors. All rights reserved. On 2016/11/21 13:32:22, sdefresne wrote: > Can this file be renamed to ios_chrome_local_session_event_router.cc? Sadly, no: In file included from ../../ios/chrome/browser/sync/sessions/ios_chrome_local_session_event_router.cc:17: In file included from ../../ios/chrome/browser/sync/ios_chrome_synced_tab_delegate.h:15: In file included from ../../ios/web/public/web_state/web_state_user_data.h:10: ../../ios/web/public/web_state/web_state.h:26:1: error: expected unqualified-id @class CRWJSInjectionReceiver; ^ ../../ios/web/public/web_state/web_state.h:27:1: error: expected unqualified-id @protocol CRWScrollableContent; ^ ../../ios/web/public/web_state/web_state.h:28:1: error: expected unqualified-id @protocol CRWWebViewProxy; ^ ../../ios/web/public/web_state/web_state.h:29:9: error: unknown type name 'id' typedef id<CRWWebViewProxy> CRWWebViewProxyType; ^ ../../ios/web/public/web_state/web_state.h:29:11: error: expected unqualified-id typedef id<CRWWebViewProxy> CRWWebViewProxyType; ^ ../../ios/web/public/web_state/web_state.h:30:1: error: expected unqualified-id @class UIView; ^ ../../ios/web/public/web_state/web_state.h:31:15: error: expected unqualified-id typedef UIView<CRWScrollableContent> CRWContentView; ^ ../../ios/web/public/web_state/web_state.h:139:11: error: unknown type name 'CRWJSInjectionReceiver' virtual CRWJSInjectionReceiver* GetJSInjectionReceiver() const = 0; ^ ../../ios/web/public/web_state/web_state.h:195:41: error: unknown type name 'CRWContentView' virtual void ShowTransientContentView(CRWContentView* content_view) = 0; ^ ../../ios/web/public/web_state/web_state.h:224:11: error: unknown type name 'CRWWebViewProxyType' virtual CRWWebViewProxyType GetWebViewProxy() const = 0; ^ 10 errors generated. ninja: build stopped: subcommand failed.
The CQ bit was checked by stkhapugin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by stkhapugin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by stkhapugin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by stkhapugin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== [ObjC ARC] Converts ios/chrome/browser/sync/sessions:sessions to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ========== to ========== [ObjC ARC] Converts ios/chrome/browser/sync/sessions:sessions to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None ========== |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
