Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Unified Diff: chrome/gpu/arc_video_accelerator.h

Issue 2513973002: Use mojo typemap to simplify the code using DmabufPlane (Closed)
Patch Set: Addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/gpu/arc_video_accelerator.h
diff --git a/chrome/gpu/arc_video_accelerator.h b/chrome/gpu/arc_video_accelerator.h
index 74ac55fd12b95574cde38fcaba113b71fea74634..cf6f1baa4d190f11c3996e2e7a79705dfc6fe36f 100644
--- a/chrome/gpu/arc_video_accelerator.h
+++ b/chrome/gpu/arc_video_accelerator.h
@@ -8,6 +8,7 @@
#include <vector>
#include "base/files/scoped_file.h"
+#include "components/arc/video_accelerator/video_accelerator.h"
namespace chromeos {
namespace arc {
@@ -77,13 +78,6 @@ class ArcVideoAccelerator {
// format of each VDA on Chromium is supported.
};
- struct DmabufPlane {
- DmabufPlane(int32_t offset, int32_t stride)
- : offset(offset), stride(stride) {}
- int32_t offset; // in bytes
- int32_t stride; // in bytes
- };
-
// The callbacks of the ArcVideoAccelerator. The user of this class should
// implement this interface.
class Client {
@@ -133,10 +127,12 @@ class ArcVideoAccelerator {
// port and index. A buffer must be successfully bound before it can be
// passed to the accelerator via UseBuffer(). Already bound buffers may be
// reused multiple times without additional bindings.
- virtual void BindDmabuf(PortType port,
- uint32_t index,
- base::ScopedFD dmabuf_fd,
- const std::vector<DmabufPlane>& dmabuf_planes) = 0;
+ virtual void BindDmabuf(
+ PortType port,
+ uint32_t index,
+ base::ScopedFD dmabuf_fd,
+ const std::vector<::arc::ArcVideoAcceleratorDmabufPlane>&
+ dmabuf_planes) = 0;
// Passes a buffer to the accelerator. For input buffer, the accelerator
// will process it. For output buffer, the accelerator will output content

Powered by Google App Engine
This is Rietveld 408576698