components/arc/video_accelerator/video_accelerator.h - Issue 2513973002: Use mojo typemap to simplify the code using DmabufPlane

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/arc/video_accelerator/video_accelerator.h

Issue 2513973002: Use mojo typemap to simplify the code using DmabufPlane (Closed)

Patch Set: Addressed comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/gpu/arc_gpu_video_decode_accelerator.cc ('K') | « components/arc/video_accelerator/OWNERS ('k') | components/arc/video_accelerator/video_accelerator_struct_traits.h » ('j') | components/arc/video_accelerator/video_accelerator_struct_traits.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENT_ARC_VIDEO_ACCELERATOR_VIDEO_ACCELERATOR_H_

	6 #define COMPONENT_ARC_VIDEO_ACCELERATOR_VIDEO_ACCELERATOR_H_

	7

	8 namespace arc {

	9

	10 struct ArcVideoAcceleratorDmabufPlane {

	11 int32_t offset; // in bytes
	dcheng 2016/12/01 01:30:50 Perhaps note in a comment why these are signed des Perhaps note in a comment why these are signed despite the fact they should only hold non-negative numbers. (IIRC, it's related to off_t being involved, but I don't remember the details anymore) yoshiki 2016/12/02 08:31:43 Powel, could you answer this question? Show quoted text On 2016/12/01 01:30:50, dcheng wrote: > Perhaps note in a comment why these are signed despite the fact they should only > hold non-negative numbers. > > (IIRC, it's related to off_t being involved, but I don't remember the details > anymore) Powel, could you answer this question? Pawel Osciak 2016/12/06 07:08:38 They are signed because client APIs use ints for t Show quoted text On 2016/12/02 08:31:43, yoshiki wrote: > On 2016/12/01 01:30:50, dcheng wrote: > > Perhaps note in a comment why these are signed despite the fact they should > only > > hold non-negative numbers. > > > > (IIRC, it's related to off_t being involved, but I don't remember the details > > anymore) > > Powel, could you answer this question? They are signed because client APIs use ints for these. yoshiki 2016/12/06 16:48:33 Ok. Let me keep as-is. Show quoted text On 2016/12/06 07:08:38, Pawel Osciak wrote: > On 2016/12/02 08:31:43, yoshiki wrote: > > On 2016/12/01 01:30:50, dcheng wrote: > > > Perhaps note in a comment why these are signed despite the fact they should > > only > > > hold non-negative numbers. > > > > > > (IIRC, it's related to off_t being involved, but I don't remember the > details > > > anymore) > > > > Powel, could you answer this question? > > They are signed because client APIs use ints for these. Ok. Let me keep as-is.
	12 int32_t stride; // in bytes

	13 };

	14

	15 } // namespace arc

	16

	17 #endif // COMPONENT_ARC_VIDEO_ACCELERATOR_VIDEO_ACCELERATOR_H_

OLD	NEW