Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(69)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: components/arc/video_accelerator/video_accelerator.h
Issue
2513973002
:
Use mojo typemap to simplify the code using DmabufPlane (Closed)
Patch Set: Addressed comments
Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/gpu/DEPS
chrome/gpu/arc_gpu_video_decode_accelerator.h
chrome/gpu/arc_gpu_video_decode_accelerator.cc
chrome/gpu/arc_video_accelerator.h
chrome/gpu/gpu_arc_video_service.h
chrome/gpu/gpu_arc_video_service.cc
components/arc/BUILD.gn
components/arc/common/typemaps.gni
components/arc/common/video_accelerator.typemap
components/arc/video_accelerator/OWNERS
components/arc/video_accelerator/video_accelerator.h
components/arc/video_accelerator/video_accelerator_struct_traits.h
components/arc/video_accelerator/video_accelerator_struct_traits.cc
View unified diff
|
Download patch
« no previous file with comments
|
« components/arc/video_accelerator/OWNERS
('k') |
components/arc/video_accelerator/video_accelerator_struct_traits.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright 2016 The Chromium Authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
#ifndef COMPONENTS_ARC_VIDEO_ACCELERATOR_VIDEO_ACCELERATOR_H_
6
#define COMPONENTS_ARC_VIDEO_ACCELERATOR_VIDEO_ACCELERATOR_H_
7
8
namespace arc {
9
10
struct ArcVideoAcceleratorDmabufPlane {
11
int32_t offset; // in bytes
12
int32_t stride; // in bytes
13
};
14
15
} // namespace arc
16
17
#endif // COMPONENTS_ARC_VIDEO_ACCELERATOR_VIDEO_ACCELERATOR_H_
OLD
NEW
« no previous file with comments
|
« components/arc/video_accelerator/OWNERS
('k') |
components/arc/video_accelerator/video_accelerator_struct_traits.h »
('j') |
no next file with comments »
Issue 2513973002: Use mojo typemap to simplify the code using DmabufPlane (Closed)
Created 4 years, 1 month ago by yoshiki
Modified 4 years ago
Reviewers: Yusuke Sato, Luis Héctor Chávez, dcheng, Pawel Osciak
Base URL:
Comments: 45
This is Rietveld
408576698
Chromium Code Reviews
Issue 2513973002:
Use mojo typemap to simplify the code using DmabufPlane (Closed)
