Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9441)

Unified Diff: chrome/browser/ui/webui/welcome_win10_ui.cc

Issue 2513953004: Adding metrics on the usefulness of the Win10 version of the Welcome Page (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/welcome_win10_ui.cc
diff --git a/chrome/browser/ui/webui/welcome_win10_ui.cc b/chrome/browser/ui/webui/welcome_win10_ui.cc
index 883415b9fe4f045c33bdf823af6e075e11ffe377..2a280ddd5d6832ef032d242206429934cb931eb2 100644
--- a/chrome/browser/ui/webui/welcome_win10_ui.cc
+++ b/chrome/browser/ui/webui/welcome_win10_ui.cc
@@ -89,15 +89,15 @@ WelcomeWin10UI::WelcomeWin10UI(content::WebUI* web_ui, const GURL& url)
static const char kCssFilePath[] = "welcome.css";
static const char kJsFilePath[] = "welcome.js";
- web_ui->AddMessageHandler(new WelcomeWin10Handler());
-
- content::WebUIDataSource* html_source =
- content::WebUIDataSource::Create(url.host());
-
// Determine which variation to show.
bool is_first_run = !UrlContainsKeyValueInQuery(url, "text", "faster");
bool is_inline_style = ShouldShowInlineStyleVariant(url);
+ web_ui->AddMessageHandler(new WelcomeWin10Handler(is_inline_style));
+
+ content::WebUIDataSource* html_source =
+ content::WebUIDataSource::Create(url.host());
+
AddLocalizedStrings(html_source, is_first_run);
if (is_inline_style) {

Powered by Google App Engine
This is Rietveld 408576698