Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.cpp

Issue 2513953002: [css-grid] Avoid double loop in positioned objects layout (Closed)
Patch Set: New version overriding layoutPositionedObjects() Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlock.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutGrid.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
index cb52b7acaa913ca94f88f90c69cc728421147d4e..d37c0eb61ab594e1f2c7a7ea030e318a11e4aa09 100644
--- a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
@@ -2491,6 +2491,7 @@ void LayoutGrid::layoutPositionedObjects(bool relayoutChildren,
for (auto* child : *positionedDescendants) {
if (isOrthogonalChild(*child)) {
// FIXME: Properly support orthogonal writing mode.
+ layoutPositionedObject(child, relayoutChildren, info);
continue;
}
@@ -2512,9 +2513,9 @@ void LayoutGrid::layoutPositionedObjects(bool relayoutChildren,
childLayer->setStaticInlinePosition(borderStart() + columnOffset);
childLayer->setStaticBlockPosition(borderBefore() + rowOffset);
}
- }
- LayoutBlock::layoutPositionedObjects(relayoutChildren, info);
+ layoutPositionedObject(child, relayoutChildren, info);
+ }
}
void LayoutGrid::offsetAndBreadthForPositionedChild(
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlock.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698