Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2513943002: [Misc] Relax getDownloadManagerService. (Closed)

Created:
4 years, 1 month ago by PEConn
Modified:
4 years, 1 month ago
Reviewers:
Ted C
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org, vitaliii
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Misc] Relax getDownloadManagerService. BUG=666744 Committed: https://crrev.com/9c44492173b89cf76fd03ca5082674dcf2d94c5e Cr-Commit-Position: refs/heads/master@{#433250}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
PEConn
PTAL We came across this causing a Tester to fail (since the method had been ...
4 years, 1 month ago (2016-11-18 15:31:06 UTC) #2
Ted C
lgtm
4 years, 1 month ago (2016-11-18 17:18:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513943002/1
4 years, 1 month ago (2016-11-18 17:20:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 18:42:44 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 18:46:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c44492173b89cf76fd03ca5082674dcf2d94c5e
Cr-Commit-Position: refs/heads/master@{#433250}

Powered by Google App Engine
This is Rietveld 408576698