Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2513923002: [heap, runtime] Set upper limit on the size of fast fixed arrays that (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap, runtime] Set upper limit on the size of fast fixed arrays that are created using new Array(N) and setLength(N). Currently the limit is based on max old generation size, which will break with the upcoming change that allows large heaps. BUG=chromium:652721 Committed: https://crrev.com/5f06c1a1f32682e6b487a861227d526f36b3b388 Cr-Commit-Position: refs/heads/master@{#41112}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/objects-inl.h View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ulan
ptal
4 years, 1 month ago (2016-11-18 13:58:23 UTC) #2
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-11-18 14:01:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513923002/1
4 years, 1 month ago (2016-11-18 14:03:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 14:31:15 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 14:31:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f06c1a1f32682e6b487a861227d526f36b3b388
Cr-Commit-Position: refs/heads/master@{#41112}

Powered by Google App Engine
This is Rietveld 408576698