Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2513913002: Instant cleanup: Remove unused Android-only cmdline switches (Closed)

Created:
4 years, 1 month ago by Marc Treib
Modified:
4 years, 1 month ago
Reviewers:
Jered
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instant cleanup: Remove unused Android-only cmdline switches These features were never launched on Android; no need to keep the switches around any longer. The field trials remain (for now), so it's still possible to use the --force-fieldtrials param. BUG=627747 Committed: https://crrev.com/db738db41ec50d536c7c4a70c994f6cabcffeb23 Cr-Commit-Position: refs/heads/master@{#433915}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -93 lines) Patch
M chrome/app/generated_resources.grd View 1 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 3 chunks +0 lines, -11 lines 0 comments Download
M components/search/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/search/search.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/search/search.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M components/search/search_android_unittest.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
D components/search/search_switches.h View 1 chunk +0 lines, -19 lines 0 comments Download
D components/search/search_switches.cc View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
Marc Treib
PTAL!
4 years, 1 month ago (2016-11-18 10:49:28 UTC) #4
Marc Treib
Ping!
4 years, 1 month ago (2016-11-22 10:15:39 UTC) #7
Jered
On 2016/11/22 10:15:39, Marc Treib wrote: > Ping! lgtm
4 years, 1 month ago (2016-11-22 16:21:01 UTC) #8
Jered
lgtm https://codereview.chromium.org/2513913002/diff/1/components/search/search_android_unittest.cc File components/search/search_android_unittest.cc (left): https://codereview.chromium.org/2513913002/diff/1/components/search/search_android_unittest.cc#oldcode18 components/search/search_android_unittest.cc:18: EXPECT_FALSE(IsInstantExtendedAPIEnabled()); I guess if we're going to bother ...
4 years, 1 month ago (2016-11-22 16:21:13 UTC) #9
Marc Treib
https://codereview.chromium.org/2513913002/diff/1/components/search/search_android_unittest.cc File components/search/search_android_unittest.cc (left): https://codereview.chromium.org/2513913002/diff/1/components/search/search_android_unittest.cc#oldcode18 components/search/search_android_unittest.cc:18: EXPECT_FALSE(IsInstantExtendedAPIEnabled()); On 2016/11/22 16:21:13, Jered wrote: > I guess ...
4 years, 1 month ago (2016-11-22 16:59:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513913002/20001
4 years, 1 month ago (2016-11-22 17:47:25 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-22 18:15:57 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 18:19:32 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/db738db41ec50d536c7c4a70c994f6cabcffeb23
Cr-Commit-Position: refs/heads/master@{#433915}

Powered by Google App Engine
This is Rietveld 408576698