Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2513903003: Disable fetching of policy for login screen apps (Closed)

Created:
4 years, 1 month ago by emaxx
Modified:
4 years, 1 month ago
Reviewers:
Thiemo Nagel
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable fetching of policy for login screen apps This disables fetching of policies for login screen apps, which used the new policy type "google/chromeos/signinextension", as DMServer started to respond with errors to requests with unknown policy types. BUG=666720, 644304 TEST=manual (run chromeos=1 build with an enrolled profile, navigate to chrome://policy, press "Reload policies", check that OK is displayed for the device policy) Committed: https://crrev.com/f14a5fdb16cda4b707b127d1c8cf62115a72f709 Cr-Commit-Position: refs/heads/master@{#433190}

Patch Set 1 #

Patch Set 2 : Disable related tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
emaxx
Thiemo, PTAL. This is a P0 fix. I haven't tested it yet, but publishing the ...
4 years, 1 month ago (2016-11-18 13:40:07 UTC) #4
emaxx
On 2016/11/18 13:40:07, emaxx wrote: > Thiemo, PTAL. This is a P0 fix. > > ...
4 years, 1 month ago (2016-11-18 13:41:13 UTC) #5
emaxx
Disabled the related tests. Still not finished running the tests locally or through trybots.
4 years, 1 month ago (2016-11-18 13:54:51 UTC) #8
Thiemo Nagel
LGTM
4 years, 1 month ago (2016-11-18 14:02:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513903003/20001
4 years, 1 month ago (2016-11-18 14:17:32 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-18 14:22:04 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 14:25:41 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f14a5fdb16cda4b707b127d1c8cf62115a72f709
Cr-Commit-Position: refs/heads/master@{#433190}

Powered by Google App Engine
This is Rietveld 408576698