[interpreter] Properly collect rhs feedback for comparisons with oddballs.

[interpreter] Properly collect rhs feedback for comparisons with oddballs.

Ignition skipped collecting NumberOrOddball feedback if the right hand
side of a relational comparison is undefined, thus leading to a
deoptimization loop, because it reported Number feedback to TurboFan.

This was caught on 3d-raytrace test of SunSpider.

R=rmcilroy@chromium.org

Committed: https://crrev.com/d240ffec32ae034e50c006f7d5715171b32bbbc4
Cr-Commit-Position: refs/heads/master@{#41094}

[Benedikt Meurer, 2016-11-18 09:15:19]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 09:15:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-11-18 09:16:17]

Hey Ross,

Here's the fix for the 3d-raytrace deopt loop.
Please take a look.

Thanks,
Benedikt

[rmcilroy, 2016-11-18 09:19:20]

Doh, thanks for the fix! LGTM

[Benedikt Meurer, 2016-11-18 09:53:45]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2016-11-18 09:53:50]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-11-18 09:53:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 10:04:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-18 10:04:27]

Description was changed from

==========
[interpreter] Properly collect rhs feedback for comparisons with oddballs.

Ignition skipped collecting NumberOrOddball feedback if the right hand
side of a relational comparison is undefined, thus leading to a
deoptimization loop, because it reported Number feedback to TurboFan.

This was caught on 3d-raytrace test of SunSpider.

R=rmcilroy@chromium.org
==========

to

==========
[interpreter] Properly collect rhs feedback for comparisons with oddballs.

Ignition skipped collecting NumberOrOddball feedback if the right hand
side of a relational comparison is undefined, thus leading to a
deoptimization loop, because it reported Number feedback to TurboFan.

This was caught on 3d-raytrace test of SunSpider.

R=rmcilroy@chromium.org

Committed: https://crrev.com/d240ffec32ae034e50c006f7d5715171b32bbbc4
Cr-Commit-Position: refs/heads/master@{#41094}
==========

[commit-bot: I haz the power, 2016-11-18 10:04:28]

Patchset 1 (id:??) landed as
https://crrev.com/d240ffec32ae034e50c006f7d5715171b32bbbc4
Cr-Commit-Position: refs/heads/master@{#41094}

[Michael Achenbach, 2016-11-18 12:00:57]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2511243004/ by machenbach@chromium.org.

The reason for reverting is: Seems to break layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....