Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2513893004: Reland of [Android] Make the test runner terminate gracefully on SIGTERM. (Closed)

Created:
4 years, 1 month ago by jbudorick
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [Android] Make the test runner terminate gracefully on SIGTERM. (patchset #1 id:1 of https://codereview.chromium.org/2511243005/ ) Reason for revert: After looking at that bot further, it's been failing occasionally w/ similar issues for a while. e.g. https://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/97567 https://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/97523 https://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/97482 https://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/97481 I'll investigate that separately, but in the meantime, I'm relanding this. Original issue's description: > Revert of [Android] Make the test runner terminate gracefully on SIGTERM. (patchset #2 id:20001 of https://codereview.chromium.org/2511733004/ ) > > Reason for revert: > Caused Android Builder to fail: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/Android%20Builder/builds/97588/steps/compile/logs/stdio > > Original issue's description: > > [Android] Make the test runner terminate gracefully on SIGTERM. > > > > This includes writing out the JSON results file, even if we have > > no results. > > > > BUG=664308 > > > > Committed: https://crrev.com/b346038701a73dbc4c1758fe9baf7b23614fbe60 > > Cr-Commit-Position: refs/heads/master@{#433234} > > TBR=katthomas@google.com,rnephew@chromium.org,jbudorick@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=664308 > > Committed: https://crrev.com/8b304e2f24383fc9e8d6c78f86d661ebbd3e1934 > Cr-Commit-Position: refs/heads/master@{#433270} TBR=katthomas@google.com,rnephew@chromium.org,fsamuel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=664308 Committed: https://crrev.com/553e2403263f200cedb4745ca30aa02ff00fa5b0 Cr-Commit-Position: refs/heads/master@{#433289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -76 lines) Patch
M build/android/pylib/local/device/local_device_test_run.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/test_runner.py View 3 chunks +106 lines, -75 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jbudorick
Created Reland of [Android] Make the test runner terminate gracefully on SIGTERM.
4 years, 1 month ago (2016-11-18 20:21:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513893004/1
4 years, 1 month ago (2016-11-18 20:22:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 20:24:34 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 20:26:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/553e2403263f200cedb4745ca30aa02ff00fa5b0
Cr-Commit-Position: refs/heads/master@{#433289}

Powered by Google App Engine
This is Rietveld 408576698