Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2513893003: [ic] Don't check full prototype chain if name is a private symbol. (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Don't check full prototype chain if name is a private symbol. BUG=chromium:664974, chromium:664802, v8:5561 Committed: https://crrev.com/4513532f6362353eaf50ec30d753a346e795b164 Cr-Commit-Position: refs/heads/master@{#41133}

Patch Set 1 #

Patch Set 2 : and JSProxy case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -24 lines) Patch
M src/ic/ic.cc View 1 10 chunks +24 lines, -18 lines 0 comments Download
M src/prototype.h View 1 1 chunk +20 lines, -6 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-664802.js View 1 1 chunk +10 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-664974.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
Igor Sheludko
PTAL
4 years, 1 month ago (2016-11-18 14:19:15 UTC) #5
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-11-21 10:50:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513893003/20001
4 years, 1 month ago (2016-11-21 10:54:42 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-21 11:21:35 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 11:21:55 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4513532f6362353eaf50ec30d753a346e795b164
Cr-Commit-Position: refs/heads/master@{#41133}

Powered by Google App Engine
This is Rietveld 408576698