third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h - Issue 2513893002: Make ifdefs consistent in WebKit/Source/core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h

Issue 2513893002: Make ifdefs consistent in WebKit/Source/core/ (Closed)

Patch Set: Fix build. Update after review. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h

diff --git a/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h b/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h

index 69d04570510f9311d02c16038e32b708bf2da1ce..9f197bc38ab8640912d460ea10da6151763bb086 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h

+++ b/third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h

@@ -336,7 +336,7 @@ class PLATFORM_EXPORT DisplayItem {

virtual bool isBegin() const { return false; }

virtual bool isEnd() const { return false; }

-#if DCHECK_IS_ON()

+#ifdef NDEBUG

virtual bool isEndAndPairedWith(DisplayItem::Type otherType) const {

return false;

}

@@ -418,7 +418,7 @@ class PLATFORM_EXPORT PairedEndDisplayItem : public DisplayItem {

size_t derivedSize)

: DisplayItem(client, type, derivedSize) {}

-#if ENABLE(ASSERT)

+#ifdef NDEBUG

bool isEndAndPairedWith(DisplayItem::Type otherType) const override = 0;

Alexander Alekseev 2016/11/18 22:32:15 This is declared in the base class only if NDEBUG

#endif