third_party/WebKit/Source/core/layout/LayoutObject.h - Issue 2513893002: Make ifdefs consistent in WebKit/Source/core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2513893002: Make ifdefs consistent in WebKit/Source/core/ (Closed)

Patch Set: Fix build. Update after review. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutObject.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h

index c4bc1dcd7bdf96640eb76f6ad202c34f5e0d966b..a7ce63c3f0e31d9a4e470c35e76395a34c02e678 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObject.h

+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h

@@ -1935,7 +1935,7 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,

m_previousVisualRect = rect;

}

-#if DCHECK_IS_ON()

+#ifndef NDEBUG

virtual bool paintInvalidationStateIsDirty() const {

Alexander Alekseev 2016/11/18 22:32:15 This is called above only if '#ifndef NDEBUG'

return backgroundChangedSinceLastPaintInvalidation() ||

shouldCheckForPaintInvalidationRegardlessOfPaintInvalidationState();