Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 2513893002: Make ifdefs consistent in WebKit/Source/core/ (Closed)
Patch Set: Limited fix to /core/ only. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Node.cpp
diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp
index aeaa766772c025ce7febc7821a9155f978936b3d..e0cf9f7a7a5c23f9d007a03ca23415f90119389b 100644
--- a/third_party/WebKit/Source/core/dom/Node.cpp
+++ b/third_party/WebKit/Source/core/dom/Node.cpp
@@ -582,7 +582,7 @@ LayoutRect Node::boundingBox() const {
return LayoutRect();
}
-#ifndef NDEBUG
+#if DCHECK_IS_ON()
inline static ShadowRoot* oldestShadowRootFor(const Node* node) {
if (!node->isElementNode())
return nullptr;
@@ -1556,7 +1556,7 @@ std::ostream& operator<<(std::ostream& ostream, const Node* node) {
return ostream << *node;
}
-#ifndef NDEBUG
+#if DCHECK_IS_ON()
String Node::toString() const {
// TODO(tkent): We implemented toString() with operator<<. We should
@@ -2525,7 +2525,7 @@ v8::Local<v8::Object> Node::associateWithWrapper(
} // namespace blink
-#ifndef NDEBUG
+#if DCHECK_IS_ON()
void showNode(const blink::Node* node) {
if (node)

Powered by Google App Engine
This is Rietveld 408576698