third_party/WebKit/Source/platform/Timer.h - Issue 2513893002: Make ifdefs consistent in WebKit/Source/core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/Timer.h

Issue 2513893002: Make ifdefs consistent in WebKit/Source/core/ (Closed)

Patch Set: Added #if DCHECK_IS_ON where needed. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/Timer.h

diff --git a/third_party/WebKit/Source/platform/Timer.h b/third_party/WebKit/Source/platform/Timer.h

index 2011a145dd915fa79a8812fcf67ed83a4d346f96..b42a0bfad6032cb754dac859e503136205fd463c 100644

--- a/third_party/WebKit/Source/platform/Timer.h

+++ b/third_party/WebKit/Source/platform/Timer.h

@@ -196,7 +196,9 @@ class UnthrottledThreadTimer : public TaskRunnerTimer<TimerFiredClass> {

NO_SANITIZE_ADDRESS

inline bool TimerBase::isActive() const {

- ASSERT(m_thread == currentThread());

+#if DCHECK_IS_ON()

+ DCHECK(m_thread == currentThread());

Yuta Kitamura 2016/11/21 09:26:12 Use DCHECK_EQ.

Alexander Alekseev 2016/11/23 09:20:30 Done.

+#endif

return m_weakPtrFactory.hasWeakPtrs();

}