third_party/WebKit/Source/core/svg/SVGScriptElement.h - Issue 2513893002: Make ifdefs consistent in WebKit/Source/core/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGScriptElement.h

Issue 2513893002: Make ifdefs consistent in WebKit/Source/core/ (Closed)

Patch Set: Added #if DCHECK_IS_ON where needed. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGScriptElement.h

diff --git a/third_party/WebKit/Source/core/svg/SVGScriptElement.h b/third_party/WebKit/Source/core/svg/SVGScriptElement.h

index a99a3543d71acb5e8cfad24b94c0b6e92c01198b..f68e7b79242075e77818ce073eda02a18fba42d9 100644

--- a/third_party/WebKit/Source/core/svg/SVGScriptElement.h

+++ b/third_party/WebKit/Source/core/svg/SVGScriptElement.h

@@ -42,7 +42,7 @@ class SVGScriptElement final : public SVGElement,

ScriptLoader* loader() const { return m_loader.get(); }

-#if ENABLE(ASSERT)

+#if DCHECK_IS_ON()

Yuta Kitamura 2016/11/21 05:32:06 The original code is correct.

Yuta Kitamura 2016/11/21 09:26:12 I was wrong. You are correct.

bool isAnimatableAttribute(const QualifiedName&) const override;

#endif