Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/svg/SVGScriptElement.cpp

Issue 2513893002: Make ifdefs consistent in WebKit/Source/core/ (Closed)
Patch Set: Added #if DCHECK_IS_ON where needed. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/core/svg/SVGScriptElement.h ('K') | « third_party/WebKit/Source/core/svg/SVGScriptElement.h ('k') | third_party/WebKit/Source/modules/filesystem/FileWriterSync.cpp » ('j') | third_party/WebKit/Source/modules/filesystem/FileWriterSync.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/svg/SVGScriptElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGScriptElement.cpp b/third_party/WebKit/Source/core/svg/SVGScriptElement.cpp
index 9bf6d5d7f040ed50287562c7056aaa0b88414ca6..a6a3a319650152a6693ff50ea8e43ea2ca875998 100644
--- a/third_party/WebKit/Source/core/svg/SVGScriptElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGScriptElement.cpp
@@ -143,7 +143,7 @@ void SVGScriptElement::dispatchLoadEvent() {
dispatchEvent(Event::create(EventTypeNames::load));
}
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
Yuta Kitamura 2016/11/21 05:32:06 Ditto.
Yuta Kitamura 2016/11/21 09:26:12 You are correct here too.
bool SVGScriptElement::isAnimatableAttribute(const QualifiedName& name) const {
if (name == SVGNames::typeAttr)
return false;
« third_party/WebKit/Source/core/svg/SVGScriptElement.h ('K') | « third_party/WebKit/Source/core/svg/SVGScriptElement.h ('k') | third_party/WebKit/Source/modules/filesystem/FileWriterSync.cpp » ('j') | third_party/WebKit/Source/modules/filesystem/FileWriterSync.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698