Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2513893002: Make ifdefs consistent in WebKit/Source/core/ (Closed)
Patch Set: Added #if DCHECK_IS_ON where needed. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObject.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h
index c4bc1dcd7bdf96640eb76f6ad202c34f5e0d966b..a7ce63c3f0e31d9a4e470c35e76395a34c02e678 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.h
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h
@@ -1935,7 +1935,7 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,
m_previousVisualRect = rect;
}
-#if DCHECK_IS_ON()
+#ifndef NDEBUG
Yuta Kitamura 2016/11/21 05:32:06 This is wrong (and the original code is wrong, too
Yuta Kitamura 2016/11/21 09:26:11 This comment was wrong. This should be DCHECK_IS_
virtual bool paintInvalidationStateIsDirty() const {
return backgroundChangedSinceLastPaintInvalidation() ||
shouldCheckForPaintInvalidationRegardlessOfPaintInvalidationState();

Powered by Google App Engine
This is Rietveld 408576698