third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h - Issue 2513893002: Make ifdefs consistent in WebKit/Source/core/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h

Issue 2513893002: Make ifdefs consistent in WebKit/Source/core/ (Closed)

Patch Set: Added #if DCHECK_IS_ON where needed. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/platform/graphics/GraphicsContext.h ('K') | « third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.h ('k') | third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h » ('j') | third_party/WebKit/Source/platform/heap/PersistentNode.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef DisplayItem_h	5 #ifndef DisplayItem_h

6 #define DisplayItem_h	6 #define DisplayItem_h

7	7

8 #include "platform/PlatformExport.h"	8 #include "platform/PlatformExport.h"

9 #include "platform/graphics/ContiguousContainer.h"	9 #include "platform/graphics/ContiguousContainer.h"

10 #include "platform/graphics/paint/DisplayItemClient.h"	10 #include "platform/graphics/paint/DisplayItemClient.h"

(...skipping 400 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
411 bool isBegin() const final { return true; }	411 bool isBegin() const final { return true; }

412 };	412 };

413	413

414 class PLATFORM_EXPORT PairedEndDisplayItem : public DisplayItem {	414 class PLATFORM_EXPORT PairedEndDisplayItem : public DisplayItem {

415 protected:	415 protected:

416 PairedEndDisplayItem(const DisplayItemClient& client,	416 PairedEndDisplayItem(const DisplayItemClient& client,

417 Type type,	417 Type type,

418 size_t derivedSize)	418 size_t derivedSize)

419 : DisplayItem(client, type, derivedSize) {}	419 : DisplayItem(client, type, derivedSize) {}

420	420

421 #if ENABLE(ASSERT)	421 #ifndef NDEBUG
	Yuta Kitamura 2016/11/21 09:26:12 This should be DCHECK_IS_ON(). This should be DCHECK_IS_ON(). Alexander Alekseev 2016/11/23 09:20:30 Done. Show quoted text On 2016/11/21 09:26:12, Yuta Kitamura wrote: > This should be DCHECK_IS_ON(). Done.
422 bool isEndAndPairedWith(DisplayItem::Type otherType) const override = 0;	422 bool isEndAndPairedWith(DisplayItem::Type otherType) const override = 0;

423 #endif	423 #endif

424	424

425 private:	425 private:

426 bool isEnd() const final { return true; }	426 bool isEnd() const final { return true; }

427 };	427 };

428	428

429 } // namespace blink	429 } // namespace blink

430	430

431 #endif // DisplayItem_h	431 #endif // DisplayItem_h

OLD	NEW