Make ifdefs consistent in WebKit/Source/core/

third_party/WebKit/Source/modules/filesystem/FileWriterSync.cpp

 /*
  * Copyright (C) 2010 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 23 matching lines @@
 #include "core/dom/ExceptionCode.h"
 #include "core/fileapi/Blob.h"
 #include "public/platform/WebFileWriter.h"
 #include "public/platform/WebURL.h"
 
 namespace blink {
 
 void FileWriterSync::write(Blob* data, ExceptionState& exceptionState) {
   ASSERT(data);
   ASSERT(writer());
-  ASSERT(m_complete);
+#if DCHECK_IS_ON()

[nhiroki, 2016/11/21 03:24:57]

Instead of adding DCHECK_IS_ON(), can you completely remove these macros from
FileWriterSync.{cpp,h}? I think bool operations are not expensive and improving
readability is more beneficial.

[Yuta Kitamura, 2016/11/21 05:32:06]

Ditto. All these changes are wrong.

[Yuta Kitamura, 2016/11/21 09:26:12]

I was wrong. I agree with nhiroki here.

[Alexander Alekseev, 2016/11/23 09:20:30]

Done.

+  DCHECK(m_complete);
+#endif
 
   prepareForWrite();
   writer()->write(position(), data->uuid());
-  ASSERT(m_complete);
+#if DCHECK_IS_ON()
+  DCHECK(m_complete);
+#endif
   if (m_error) {
     FileError::throwDOMException(exceptionState, m_error);
     return;
   }
   setPosition(position() + data->size());
   if (position() > length())
     setLength(position());
 }
 
 void FileWriterSync::seek(long long position, ExceptionState& exceptionState) {
   ASSERT(writer());
-  ASSERT(m_complete);
+#if DCHECK_IS_ON()
+  DCHECK(m_complete);
+#endif
   seekInternal(position);
 }
 
 void FileWriterSync::truncate(long long offset,
                               ExceptionState& exceptionState) {
   ASSERT(writer());
-  ASSERT(m_complete);
+#if DCHECK_IS_ON()
+  DCHECK(m_complete);
+#endif
   if (offset < 0) {
     exceptionState.throwDOMException(InvalidStateError,
                                      FileError::invalidStateErrorMessage);
     return;
   }
   prepareForWrite();
   writer()->truncate(offset);
-  ASSERT(m_complete);
+#if DCHECK_IS_ON()
+  DCHECK(m_complete);
+#endif
   if (m_error) {
     FileError::throwDOMException(exceptionState, m_error);
     return;
   }
   if (offset < position())
     setPosition(offset);
   setLength(offset);
 }
 
 void FileWriterSync::didWrite(long long bytes, bool complete) {
@@ skipping 40 matching lines @@
 #endif
 }
 
 FileWriterSync::~FileWriterSync() {}
 
 DEFINE_TRACE(FileWriterSync) {
   FileWriterBase::trace(visitor);
 }
 
 }  // namespace blink