Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Issue 2513863002: cc: Delete channel abstraction between proxies. (Closed)

Created:
4 years, 1 month ago by Khushal
Modified:
4 years, 1 month ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Delete channel abstraction between proxies. The abstraction is now unnecessary. It was added to allow a mode where these components may not be across threads, which is no longer needed. The proxies can talk to each other directly. BUG=628746 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/12020cd40a727019ace7f438018018f266538ba7 Cr-Commit-Position: refs/heads/master@{#433496}

Patch Set 1 #

Patch Set 2 : Delete channel abstraction #

Patch Set 3 : rebase #

Patch Set 4 : include #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -802 lines) Patch
M cc/BUILD.gn View 1 2 3 4 3 chunks +0 lines, -6 lines 0 comments Download
D cc/test/fake_channel_impl.h View 1 chunk +0 lines, -33 lines 0 comments Download
D cc/test/fake_channel_impl.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M cc/test/layer_tree_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
D cc/trees/channel_impl.h View 1 chunk +0 lines, -39 lines 0 comments Download
D cc/trees/channel_main.h View 1 chunk +0 lines, -74 lines 0 comments Download
M cc/trees/layer_tree_host_in_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/proxy_impl.h View 1 2 3 4 3 chunks +9 lines, -7 lines 0 comments Download
M cc/trees/proxy_impl.cc View 13 chunks +34 lines, -11 lines 0 comments Download
M cc/trees/proxy_main.h View 1 2 3 5 chunks +18 lines, -16 lines 0 comments Download
M cc/trees/proxy_main.cc View 1 2 3 19 chunks +118 lines, -44 lines 0 comments Download
D cc/trees/threaded_channel.h View 1 chunk +0 lines, -208 lines 0 comments Download
D cc/trees/threaded_channel.cc View 1 chunk +0 lines, -345 lines 0 comments Download

Messages

Total messages: 42 (29 generated)
Khushal
And moar clean up.
4 years, 1 month ago (2016-11-18 02:51:48 UTC) #3
enne (OOO)
lgtm
4 years, 1 month ago (2016-11-21 00:53:03 UTC) #17
Khushal
On 2016/11/21 00:53:03, enne wrote: > lgtm Thanks enne!
4 years, 1 month ago (2016-11-21 06:53:58 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513863002/60001
4 years, 1 month ago (2016-11-21 06:54:16 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513863002/80001
4 years, 1 month ago (2016-11-21 07:03:46 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED, no build URL)
4 years, 1 month ago (2016-11-21 07:04:57 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513863002/80001
4 years, 1 month ago (2016-11-21 07:14:09 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED, no build URL)
4 years, 1 month ago (2016-11-21 07:14:58 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513863002/80001
4 years, 1 month ago (2016-11-21 08:14:04 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: linux_precise_blink_rel on master.tryserver.blink (JOB_FAILED, no build URL)
4 years, 1 month ago (2016-11-21 08:15:18 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513863002/80001
4 years, 1 month ago (2016-11-21 08:19:07 UTC) #37
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-21 09:23:15 UTC) #40
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 09:26:07 UTC) #42
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/12020cd40a727019ace7f438018018f266538ba7
Cr-Commit-Position: refs/heads/master@{#433496}

Powered by Google App Engine
This is Rietveld 408576698