Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2513843002: Revert "[Android] Keep top controls visible until an update from a Tab." (Closed)

Created:
4 years, 1 month ago by Ian Wen
Modified:
4 years, 1 month ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/2883
Project:
chromium
Visibility:
Public.

Description

Revert "[Android] Keep top controls visible until an update from a Tab." This reverts commit 2e2ed096513eb9e7168498fd167dacc2888b338d, because after commit https://codereview.chromium.org/2106753004, setPositionForTab is no longer called if there is no change in content offset. BUG=660935 R=tedchoc@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/6eea3cdf56c513aa5cc9d08522d1954ba634113b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java View 3 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Ian Wen
tedchoc@ for review. aelias@ and bokan@ for cc. This CL makes M55 to restore Chrome's ...
4 years, 1 month ago (2016-11-18 00:58:59 UTC) #2
Ted C
lgtm
4 years, 1 month ago (2016-11-21 20:50:14 UTC) #5
Ian Wen
4 years, 1 month ago (2016-11-21 21:09:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6eea3cdf56c513aa5cc9d08522d1954ba634113b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698