Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2513833002: Fix the order of expected and actual values in PercentageResolutionSize test. (Closed)

Created:
4 years, 1 month ago by Gleb Lanbin
Modified:
4 years, 1 month ago
Reviewers:
cbiesinger, ikilpatrick
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the order of expected and actual values in PercentageResolutionSize test. EXPECT_EQ expects that the 1st argument is the expected value. If the order is wrong it produces a confusing error message BUG=635619 Committed: https://crrev.com/e76a6397f156d4395468de7fa97fd46186f7c9bd Cr-Commit-Position: refs/heads/master@{#433335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Gleb Lanbin
4 years, 1 month ago (2016-11-18 00:11:58 UTC) #3
Gleb Lanbin
4 years, 1 month ago (2016-11-18 23:39:42 UTC) #8
ikilpatrick
lgtm
4 years, 1 month ago (2016-11-18 23:40:35 UTC) #10
cbiesinger
lgtm, sorry for the delay! I think we may have other tests that also get ...
4 years, 1 month ago (2016-11-18 23:40:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513833002/1
4 years, 1 month ago (2016-11-18 23:41:34 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 23:57:05 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 00:05:21 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e76a6397f156d4395468de7fa97fd46186f7c9bd
Cr-Commit-Position: refs/heads/master@{#433335}

Powered by Google App Engine
This is Rietveld 408576698