Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 251383004: Tests for CL 258503008

Created:
6 years, 8 months ago by Jacob
Modified:
6 years, 8 months ago
Reviewers:
vsm, blois
CC:
reviews+dom_dartlang.org
Visibility:
Public.

Description

Tests for CL 258503008 BUG=

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+400 lines, -1 line) Patch
A LayoutTests/dart/inspector/sample_library.dart View 1 chunk +74 lines, -0 lines 0 comments Download
A LayoutTests/dart/inspector/utils.dart View 1 chunk +325 lines, -0 lines 7 comments Download
A + LayoutTests/dart/inspector/utils.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Jacob
6 years, 8 months ago (2014-04-24 20:41:10 UTC) #1
vsm
Is there an expected result file to go with this?
6 years, 8 months ago (2014-04-24 23:44:27 UTC) #2
Jacob
On 2014/04/24 23:44:27, vsm wrote: > Is there an expected result file to go with ...
6 years, 8 months ago (2014-04-24 23:47:36 UTC) #3
vsm
6 years, 8 months ago (2014-04-25 00:01:13 UTC) #4
lgtm

https://codereview.chromium.org/251383004/diff/1/LayoutTests/dart/inspector/u...
File LayoutTests/dart/inspector/utils.dart (right):

https://codereview.chromium.org/251383004/diff/1/LayoutTests/dart/inspector/u...
LayoutTests/dart/inspector/utils.dart:22: * methods from a different library.
Is this just for testing purposes?

https://codereview.chromium.org/251383004/diff/1/LayoutTests/dart/inspector/u...
LayoutTests/dart/inspector/utils.dart:107:
expect(_Utils.getObjectCompletions(Foo, sampleLibraryUrl),
Test privacy here as well?

https://codereview.chromium.org/251383004/diff/1/LayoutTests/dart/inspector/u...
LayoutTests/dart/inspector/utils.dart:127: completions =
_Utils.getLibraryCompletionsIncludingImports(sampleLibraryUrl);
length

https://codereview.chromium.org/251383004/diff/1/LayoutTests/dart/inspector/u...
LayoutTests/dart/inspector/utils.dart:148:
expect(_Utils.describeFunction(b.barMember1), equals('barMember1() => 42;'));
length

https://codereview.chromium.org/251383004/diff/1/LayoutTests/dart/inspector/u...
LayoutTests/dart/inspector/utils.dart:151:
expect(_Utils.describeFunction(barMember1), equals('barMember1() => 42;'));
length

https://codereview.chromium.org/251383004/diff/1/LayoutTests/dart/inspector/u...
LayoutTests/dart/inspector/utils.dart:254: // private field.
It might be better to just import a second sample library and test across that
boundary rather than depend on vm internals.  Someone will change this.  :-)

https://codereview.chromium.org/251383004/diff/1/LayoutTests/dart/inspector/u...
LayoutTests/dart/inspector/utils.dart:259: var properties =
_Utils.getLibraryProperties(sampleLibraryUrl, true, false);
length

Powered by Google App Engine
This is Rietveld 408576698