Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2513823002: tweak the focus rectangle of TrayBackgroundView objects (Closed)

Created:
4 years, 1 month ago by xiaoyinh(OOO Sep 11-29)
Modified:
4 years, 1 month ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tweak the focus rectangle of TrayBackgroundView objects BUG=640678 TEST=Manually tested on lock screen and signin screen, also after signin. Committed: https://crrev.com/dcbbdb471687aa0a5bd8ad5d32eea3d11152bedc Cr-Commit-Position: refs/heads/master@{#433662}

Patch Set 1 #

Patch Set 2 : incorporate comments and rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M ash/common/system/tray/actionable_view.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M ash/common/system/tray/tray_background_view.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/common/system/tray/tray_background_view.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (19 generated)
xiaoyinh(OOO Sep 11-29)
4 years, 1 month ago (2016-11-18 00:12:23 UTC) #4
tdanderson
On 2016/11/18 00:12:23, xiaoyinh wrote: Please take a look at comment #9 on the bug. ...
4 years, 1 month ago (2016-11-18 02:26:55 UTC) #7
xiaoyinh(OOO Sep 11-29)
tdanderson@, please take another look. Screenshots are shared at comment #12 on the bug. Thanks!
4 years, 1 month ago (2016-11-19 00:27:00 UTC) #10
tdanderson
LGTM
4 years, 1 month ago (2016-11-21 20:14:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513823002/40001
4 years, 1 month ago (2016-11-21 21:50:38 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-21 21:58:01 UTC) #24
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 22:05:42 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dcbbdb471687aa0a5bd8ad5d32eea3d11152bedc
Cr-Commit-Position: refs/heads/master@{#433662}

Powered by Google App Engine
This is Rietveld 408576698