Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2513753003: Add string16 and name/title support to aura::PropertyConverter. (Closed)

Created:
4 years, 1 month ago by msw
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add string16 and name/title support to aura::PropertyConverter. BUG=665245 TEST=Automated R=sky@chromium.org Committed: https://crrev.com/c996ed6fe7db9b512d465ae65dc85d30b7efc745 Cr-Commit-Position: refs/heads/master@{#433428}

Patch Set 1 #

Patch Set 2 : Register name and title properties. #

Patch Set 3 : Sync and rebase. #

Patch Set 4 : Update failing test to ack all changes as failed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -4 lines) Patch
M ui/aura/mus/property_converter.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/aura/mus/property_converter.cc View 1 5 chunks +28 lines, -0 lines 0 comments Download
M ui/aura/mus/property_converter_unittest.cc View 1 2 4 chunks +38 lines, -2 lines 0 comments Download
M ui/aura/mus/window_tree_client_unittest.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
msw
Hey Scott, please take a look; thanks!
4 years, 1 month ago (2016-11-18 18:34:38 UTC) #4
sky
LGTM
4 years, 1 month ago (2016-11-18 18:39:42 UTC) #7
msw
I updated the failing test to ack all changes; I presume that a title or ...
4 years, 1 month ago (2016-11-18 21:37:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513753003/80001
4 years, 1 month ago (2016-11-18 21:38:49 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/276169)
4 years, 1 month ago (2016-11-19 01:56:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513753003/80001
4 years, 1 month ago (2016-11-19 19:52:38 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 1 month ago (2016-11-19 23:55:56 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 23:58:25 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c996ed6fe7db9b512d465ae65dc85d30b7efc745
Cr-Commit-Position: refs/heads/master@{#433428}

Powered by Google App Engine
This is Rietveld 408576698