Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 251373003: Set PermissionBubbleView to move with the anchor. (Closed)

Created:
6 years, 8 months ago by leng
Modified:
6 years, 8 months ago
Reviewers:
Greg Billock
CC:
chromium-reviews, tfarina, markusheintz_
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Set PermissionBubbleView to move with the anchor. This fixes a bug where the bubble disappears when the window resizes. BUG=366215 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266096

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/views/website_settings/permissions_bubble_view.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
leng
6 years, 8 months ago (2014-04-23 23:16:20 UTC) #1
Greg Billock
On 2014/04/23 23:16:20, leng wrote: lgtm
6 years, 8 months ago (2014-04-24 20:28:19 UTC) #2
leng
The CQ bit was checked by leng@chromium.org
6 years, 8 months ago (2014-04-24 20:48:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/251373003/1
6 years, 8 months ago (2014-04-24 21:15:39 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 23:05:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_x64_rel
6 years, 8 months ago (2014-04-24 23:05:09 UTC) #6
leng
The CQ bit was checked by leng@chromium.org
6 years, 8 months ago (2014-04-24 23:21:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/251373003/1
6 years, 8 months ago (2014-04-24 23:25:26 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 02:44:31 UTC) #9
Message was sent while issue was closed.
Change committed as 266096

Powered by Google App Engine
This is Rietveld 408576698