Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2513673005: Vulcanize Settings (Closed)

Created:
4 years, 1 month ago by michaelpg
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Vulcanize Settings Hacky script to flatten Settings via grit before vulcanizing. NOCOMMIT=TRUE CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : don't error on applied patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -1 line) Patch
A chrome/browser/resources/settings/flatten_settings.py View 1 chunk +131 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings.html View 1 chunk +7 lines, -0 lines 0 comments Download
A chrome/browser/resources/settings/vulcanize.py View 1 chunk +111 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.cc View 1 chunk +7 lines, -1 line 0 comments Download
A patch_vulcanize.sh View 1 1 chunk +19 lines, -0 lines 0 comments Download
M third_party/polymer/v1_0/reproduce.sh View 1 chunk +1 line, -0 lines 0 comments Download
M tools/copyright_scanner/third_party_files_whitelist.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (3 generated)
michaelpg
Description was changed from ========== Vulcanize Settings Hacky script to flatten Settings via grit before ...
4 years, 1 month ago (2016-11-19 02:05:17 UTC) #1
michaelpg
Description was changed from ========== Vulcanize Settings Hacky script to flatten Settings via grit before ...
4 years, 1 month ago (2016-11-19 03:38:26 UTC) #2
michaelpg
4 years, 1 month ago (2016-11-23 06:20:49 UTC) #3
Message was sent while issue was closed. 
Description was changed from

==========
Vulcanize Settings

Hacky script to flatten Settings via grit before vulcanizing.

NOCOMMIT=TRUE
==========

to

==========
Vulcanize Settings

Hacky script to flatten Settings via grit before vulcanizing.

NOCOMMIT=TRUE
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

Powered by Google App Engine
This is Rietveld 408576698