Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 module ash.mojom; | |
| 6 | |
| 7 // Describes a third-party VPN provided by an extension (e.g. Cisco AnyConnect). | |
| 8 struct ThirdPartyVpnProvider { | |
| 9 string name; | |
| 10 string extension_id; | |
| 11 }; | |
| 12 | |
| 13 // Manages the VPN provider list in ash. Allows extension-backed VPN providers | |
| 14 // to be added. Ash handles the built-in OpenVPN / L2TP provider internally. | |
| 15 interface VpnList { | |
| 16 // Sets the client interface (usually provided by chrome browser). | |
| 17 SetClient(VpnListClient client); | |
|
stevenjb
2016/11/19 00:04:58
This just seems confusing to me. It seems like the
| |
| 18 | |
| 19 // Sets the list of third-party VPN providers. The |providers| array may be | |
| 20 // empty to clear the list (e.g. after the last third-party VPN extension is | |
| 21 // uninstalled). | |
| 22 SetThirdPartyVpnProviders(array<ThirdPartyVpnProvider> providers); | |
| 23 }; | |
| 24 | |
| 25 // Allows ash to make requests of chrome browser, e.g. to show webui settings. | |
| 26 interface VpnListClient { | |
| 27 // Shows the configuration page for the built-in OpenVPN / L2TP provider. | |
| 28 ShowBuiltInAddNetworkPage(); | |
| 29 | |
| 30 // Shows the configuration page for a third-party VPN. |extension_id| must be | |
| 31 // a valid, non-empty extension ID. | |
| 32 ShowThirdPartyAddNetworkPage(string extension_id); | |
|
stevenjb
2016/11/19 00:04:58
In theory we could make this a single method, with
| |
| 33 }; | |
| OLD | NEW |