Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2513673003: [ObjC ARC] Converts ios/chrome/common/app_group:app_group to ARC.Automatically generated ARCMigra… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
Reviewers:
sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/common/app_group:app_group to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/cdf2457880cd0ce7bf7d58a5a8c8dd4c559dc521 Cr-Commit-Position: refs/heads/master@{#433530}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M ios/chrome/common/app_group/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/common/app_group/app_group_constants.mm View 2 chunks +5 lines, -2 lines 0 comments Download
M ios/chrome/common/app_group/app_group_metrics.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
stkhapugin
PTAL. Passes downstream tests.🙃
4 years, 1 month ago (2016-11-21 12:28:17 UTC) #6
sdefresne
lgtm
4 years, 1 month ago (2016-11-21 12:37:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513673003/1
4 years, 1 month ago (2016-11-21 13:12:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 14:14:40 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 14:16:20 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cdf2457880cd0ce7bf7d58a5a8c8dd4c559dc521
Cr-Commit-Position: refs/heads/master@{#433530}

Powered by Google App Engine
This is Rietveld 408576698