Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: ash/common/system/tray/system_tray_unittest.cc

Issue 2513653002: Disabled SystemTrayTest.NullDefaultViewIsNotRecorded on Windows due to flakiness. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/system/tray/system_tray_unittest.cc
diff --git a/ash/common/system/tray/system_tray_unittest.cc b/ash/common/system/tray/system_tray_unittest.cc
index 4e770956b1eb24781e38bcdd741039a54f5c2531..6a9c270fc2058a587173a9288d6ebcbb172f8e0a 100644
--- a/ash/common/system/tray/system_tray_unittest.cc
+++ b/ash/common/system/tray/system_tray_unittest.cc
@@ -121,9 +121,15 @@ TEST_F(SystemTrayTest, NotRecordedtemsAreNotRecorded) {
RunAllPendingInMessageLoop();
}
+// TODO(bruthig): Re-enable. See https://crbug.com/665960.
+#if defined(OS_WIN)
+#define MAYBE_NullDefaultViewIsNotRecorded DISABLED_NullDefaultViewIsNotRecorded
+#else
+#define MAYBE_NullDefaultViewIsNotRecorded NullDefaultViewIsNotRecorded
+#endif
// Verifies null default views are not recorded in the
// "Ash.SystemMenu.DefaultView.VisibleItems" histogram.
-TEST_F(SystemTrayTest, NullDefaultViewIsNotRecorded) {
+TEST_F(SystemTrayTest, MAYBE_NullDefaultViewIsNotRecorded) {
SystemTray* tray = GetPrimarySystemTray();
ASSERT_TRUE(tray->GetWidget());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698