Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2513653002: Disabled SystemTrayTest.NullDefaultViewIsNotRecorded on Windows due to flakiness. (Closed)

Created:
4 years, 1 month ago by bruthig
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabled SystemTrayTest.NullDefaultViewIsNotRecorded on Windows due to flakiness. BUG=665960 TBR=sky@chromium.org Committed: https://crrev.com/7c15af06d9e97c6221cb2c5a62584c43336b963a Cr-Commit-Position: refs/heads/master@{#432916}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M ash/common/system/tray/system_tray_unittest.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
bruthig
sky@, I've TBR'd you on this change. Can you take a look when you get ...
4 years, 1 month ago (2016-11-17 17:24:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513653002/1
4 years, 1 month ago (2016-11-17 17:24:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/123767)
4 years, 1 month ago (2016-11-17 17:35:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513653002/1
4 years, 1 month ago (2016-11-17 17:44:34 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 18:22:25 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7c15af06d9e97c6221cb2c5a62584c43336b963a Cr-Commit-Position: refs/heads/master@{#432916}
4 years, 1 month ago (2016-11-17 18:25:29 UTC) #16
sky
4 years, 1 month ago (2016-11-17 20:19:07 UTC) #17
Message was sent while issue was closed.
We are going to turn off ash_unittests on window shortly, so I won't bother
investigating. LGTM

Powered by Google App Engine
This is Rietveld 408576698