Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2513643002:
Introduce adjustFloatLogicalTopForPagination(), to offload positionAndLayoutFloat(). (Closed)
|
Created:
4 years, 1 month ago by mstensho (USE GERRIT) Modified:
4 years, 1 month ago Reviewers:
szager1 CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionIntroduce adjustFloatLogicalTopForPagination(), to offload positionAndLayoutFloat().
Also renamed a variable from childBox to child in positionAndLayoutFloat().
BUG=663942
Committed: https://crrev.com/523855f49df9f2f9ab9701b2488e4708ef908391
Cr-Commit-Position: refs/heads/master@{#433143}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Code review #
Messages
Total messages: 22 (14 generated)
The CQ bit was checked by mstensho@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mstensho@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mstensho@opera.com changed reviewers: + szager@chromium.org
lgtm with nit... https://codereview.chromium.org/2513643002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right): https://codereview.chromium.org/2513643002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:1058: LayoutUnit LayoutBlockFlow::adjustFloatForPagination( Can you rename this to something that indicates that it's adjusting the logical top? Something like adjustFloatLogicalTopForPagination.
Description was changed from ========== Introduce adjustFloatForPagination(), to offload positionAndLayoutFloat(). Also renamed a variable from childBox to child in positionAndLayoutFloat(). BUG=663942 ========== to ========== Introduce adjustFloatLogicalTopForPagination(), to offload positionAndLayoutFloat(). Also renamed a variable from childBox to child in positionAndLayoutFloat(). BUG=663942 ==========
https://codereview.chromium.org/2513643002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right): https://codereview.chromium.org/2513643002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:1058: LayoutUnit LayoutBlockFlow::adjustFloatForPagination( On 2016/11/17 19:27:52, szager1 wrote: > Can you rename this to something that indicates that it's adjusting the logical > top? Something like adjustFloatLogicalTopForPagination. Done.
The CQ bit was checked by mstensho@opera.com
The patchset sent to the CQ was uploaded after l-g-t-m from szager@chromium.org Link to the patchset: https://codereview.chromium.org/2513643002/#ps20001 (title: "Code review")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by mstensho@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Introduce adjustFloatLogicalTopForPagination(), to offload positionAndLayoutFloat(). Also renamed a variable from childBox to child in positionAndLayoutFloat(). BUG=663942 ========== to ========== Introduce adjustFloatLogicalTopForPagination(), to offload positionAndLayoutFloat(). Also renamed a variable from childBox to child in positionAndLayoutFloat(). BUG=663942 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Introduce adjustFloatLogicalTopForPagination(), to offload positionAndLayoutFloat(). Also renamed a variable from childBox to child in positionAndLayoutFloat(). BUG=663942 ========== to ========== Introduce adjustFloatLogicalTopForPagination(), to offload positionAndLayoutFloat(). Also renamed a variable from childBox to child in positionAndLayoutFloat(). BUG=663942 Committed: https://crrev.com/523855f49df9f2f9ab9701b2488e4708ef908391 Cr-Commit-Position: refs/heads/master@{#433143} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/523855f49df9f2f9ab9701b2488e4708ef908391 Cr-Commit-Position: refs/heads/master@{#433143} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
