Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 251363003: Add OVERRIDE annotation where appropriate in devtools_agent.h (Closed)

Created:
6 years, 8 months ago by eustas
Modified:
6 years, 8 months ago
Reviewers:
pfeldman, yurys
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add OVERRIDE annotation where appropriate in devtools_agent.h BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266016

Patch Set 1 #

Patch Set 2 : fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M content/renderer/devtools/devtools_agent.h View 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
eustas
6 years, 8 months ago (2014-04-24 06:24:42 UTC) #1
yurys
lgtm
6 years, 8 months ago (2014-04-24 07:20:17 UTC) #2
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 8 months ago (2014-04-24 07:20:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/251363003/10001
6 years, 8 months ago (2014-04-24 08:26:34 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 09:12:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 09:12:39 UTC) #6
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 8 months ago (2014-04-24 10:23:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/251363003/10001
6 years, 8 months ago (2014-04-24 11:00:15 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 12:18:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 12:18:42 UTC) #10
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 8 months ago (2014-04-24 12:45:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/251363003/10001
6 years, 8 months ago (2014-04-24 12:56:47 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 14:18:33 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-24 14:18:34 UTC) #14
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 8 months ago (2014-04-24 15:28:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/251363003/10001
6 years, 8 months ago (2014-04-24 15:29:40 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 22:54:14 UTC) #17
Message was sent while issue was closed. 
Change committed as 266016

Powered by Google App Engine
This is Rietveld 408576698