ChromeOS OOBE: use old-style bubble for OOBE Accessibility popup.

ChromeOS OOBE: use old-style bubble for OOBE Accessibility popup.

"Classic" ChromeOS OOBE requires old-style bubble to display Accessibility
popup. This change adds special flag to revert bubble style to old design
for "Classic" OOBE.

BUG=641866
Committed: https://crrev.com/a713652fa5868b8d3d5dae03856f8e785b5fcff7
Cr-Commit-Position: refs/heads/master@{#433060}

[Alexander Alekseev, 2016-11-17 11:13:13]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 11:13:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexander Alekseev, 2016-11-17 11:13:50]

alemate@chromium.org changed reviewers:
+ xiyuan@chromium.org

[Alexander Alekseev, 2016-11-17 11:13:50]

Please review.

(See the issue for details.)

[commit-bot: I haz the power, 2016-11-17 11:21:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 11:21:51]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2016-11-17 17:07:13]

Just nits

https://codereview.chromium.org/2513583002/diff/1/ui/login/bubble.js
File ui/login/bubble.js (right):

https://codereview.chromium.org/2513583002/diff/1/ui/login/bubble.js#newcode141
ui/login/bubble.js:141: var style_classlist = ['bubble-right', 'bubble-left',
nit: style_classlist -> styleClassList

https://codereview.chromium.org/2513583002/diff/1/ui/login/bubble.js#newcode152
ui/login/bubble.js:152: * @param {!Attachment} opt_attachment Bubble attachment
(on which side of
opt_ prefix means optional, but {!Attachment} means this arg must be set. The
two are not consistent.

If we want to get rid of opt_, please move it before opt_content to keep all
opt_ args at the end. Otherwise, update the doc to {Attachment=}

[Alexander Alekseev, 2016-11-17 23:13:57]

https://codereview.chromium.org/2513583002/diff/1/ui/login/bubble.js
File ui/login/bubble.js (right):

https://codereview.chromium.org/2513583002/diff/1/ui/login/bubble.js#newcode141
ui/login/bubble.js:141: var style_classlist = ['bubble-right', 'bubble-left',
On 2016/11/17 17:07:13, xiyuan wrote:
> nit: style_classlist -> styleClassList

Done.

https://codereview.chromium.org/2513583002/diff/1/ui/login/bubble.js#newcode152
ui/login/bubble.js:152: * @param {!Attachment} opt_attachment Bubble attachment
(on which side of
On 2016/11/17 17:07:13, xiyuan wrote:
> opt_ prefix means optional, but {!Attachment} means this arg must be set. The
> two are not consistent.
> 
> If we want to get rid of opt_, please move it before opt_content to keep all
> opt_ args at the end. Otherwise, update the doc to {Attachment=}

Done.

[Alexander Alekseev, 2016-11-17 23:14:21]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 23:16:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2016-11-17 23:23:38]

lgtm

[commit-bot: I haz the power, 2016-11-18 01:20:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 01:20:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Alexander Alekseev, 2016-11-18 01:27:51]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2016-11-18 01:29:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 03:26:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-18 03:32:15]

Description was changed from

==========
ChromeOS OOBE: use old-style bubble for OOBE Accessibility popup.

"Classic" ChromeOS OOBE requires old-style bubble to display Accessibility
popup. This change adds special flag to revert bubble style to old design
for "Classic" OOBE.

BUG=641866
==========

to

==========
ChromeOS OOBE: use old-style bubble for OOBE Accessibility popup.

"Classic" ChromeOS OOBE requires old-style bubble to display Accessibility
popup. This change adds special flag to revert bubble style to old design
for "Classic" OOBE.

BUG=641866

Committed: https://crrev.com/a713652fa5868b8d3d5dae03856f8e785b5fcff7
Cr-Commit-Position: refs/heads/master@{#433060}
==========

[commit-bot: I haz the power, 2016-11-18 03:32:18]

Patchset 2 (id:??) landed as
https://crrev.com/a713652fa5868b8d3d5dae03856f8e785b5fcff7
Cr-Commit-Position: refs/heads/master@{#433060}