Update the V8 version for Chromium branch 56.

Update the V8 version for Chromium branch 56.

This is a roll-back to 5.6.309. This is the most stable candidate out of the latest Canaries.

If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back.

When in doubt please try to contact the committer and reviewers of this CL before reverting it.

TBR=machenbach@chromium.org

Committed: https://crrev.com/194ed1a9cf5a86775bca4f976bc9e8b7c3f733d6
Cr-Commit-Position: refs/heads/master@{#432876}

[vogelheim, 2016-11-17 14:29:42]

The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 14:29:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 14:35:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 14:35:20]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Michael Achenbach, 2016-11-17 14:43:12]

lgtm

[vogelheim, 2016-11-17 14:45:55]

The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 14:46:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 14:50:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 14:50:14]

Dry run: This issue passed the CQ dry run.

[vogelheim, 2016-11-17 14:58:13]

The CQ bit was checked by vogelheim@chromium.org

[vogelheim, 2016-11-17 14:58:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/2513573003/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-11-17 14:58:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 15:02:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 15:05:57]

Description was changed from

==========
Update the V8 version for Chromium branch 56.

This is a roll-back to 5.6.309. This is the most stable candidate out of the
latest Canaries.

If this commit results in failures in Blink please contact the Blink sheriff.
They may need to make changes to Blink because of the roll-back.

When in doubt please try to contact the committer and reviewers of this CL
before reverting it.

TBR=machenbach@chromium.org
NOTRY=true
==========

to

==========
Update the V8 version for Chromium branch 56.

This is a roll-back to 5.6.309. This is the most stable candidate out of the
latest Canaries.

If this commit results in failures in Blink please contact the Blink sheriff.
They may need to make changes to Blink because of the roll-back.

When in doubt please try to contact the committer and reviewers of this CL
before reverting it.

TBR=machenbach@chromium.org
NOTRY=true

Committed: https://crrev.com/194ed1a9cf5a86775bca4f976bc9e8b7c3f733d6
Cr-Commit-Position: refs/heads/master@{#432876}
==========

[commit-bot: I haz the power, 2016-11-17 15:05:58]

Patchset 2 (id:??) landed as
https://crrev.com/194ed1a9cf5a86775bca4f976bc9e8b7c3f733d6
Cr-Commit-Position: refs/heads/master@{#432876}

[vogelheim, 2016-11-17 16:30:48]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2512473003/ by vogelheim@chromium.org.

The reason for reverting is: There's several breakages with this CL in the blame
list..

[Michael Achenbach, 2016-11-17 16:45:18]

On 2016/11/17 16:30:48, vogelheim wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/2512473003/ by mailto:vogelheim@chromium.org.
> 
> The reason for reverting is: There's several breakages with this CL in the
blame
> list..

Fine, please reland this without the NOTRY. Best use this CL.

[Michael Achenbach, 2016-11-17 16:48:03]

Description was changed from

==========
Update the V8 version for Chromium branch 56.

This is a roll-back to 5.6.309. This is the most stable candidate out of the
latest Canaries.

If this commit results in failures in Blink please contact the Blink sheriff.
They may need to make changes to Blink because of the roll-back.

When in doubt please try to contact the committer and reviewers of this CL
before reverting it.

TBR=machenbach@chromium.org
NOTRY=true

Committed: https://crrev.com/194ed1a9cf5a86775bca4f976bc9e8b7c3f733d6
Cr-Commit-Position: refs/heads/master@{#432876}
==========

to

==========
Update the V8 version for Chromium branch 56.

This is a roll-back to 5.6.309. This is the most stable candidate out of the
latest Canaries.

If this commit results in failures in Blink please contact the Blink sheriff.
They may need to make changes to Blink because of the roll-back.

When in doubt please try to contact the committer and reviewers of this CL
before reverting it.

TBR=machenbach@chromium.org

Committed: https://crrev.com/194ed1a9cf5a86775bca4f976bc9e8b7c3f733d6
Cr-Commit-Position: refs/heads/master@{#432876}
==========

[Michael Achenbach, 2016-11-17 16:48:19]

Trying reland.

[Michael Achenbach, 2016-11-17 16:48:23]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-11-17 16:48:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Achenbach, 2016-11-17 16:50:47]

For the record, if this CL doesn't stick, it's not this CLs fault. There'd be
another one that landed wronly in the meantime and we'd need to figure out which
one.

[commit-bot: I haz the power, 2016-11-17 18:00:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 18:00:39]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Michael Achenbach, 2016-11-17 18:49:53]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-11-17 18:50:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 18:57:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 18:57:31]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Michael Achenbach, 2016-11-17 19:01:21]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-11-17 19:02:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 20:10:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 20:10:26]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Michael Achenbach, 2016-11-17 21:02:46]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-11-17 21:04:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 21:13:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 21:13:07]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Russell (switch to Gerrit), 2016-11-17 21:44:08]

On 2016/11/17 16:30:48, vogelheim wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/2512473003/ by mailto:vogelheim@chromium.org.
> 
> The reason for reverting is: There's several breakages with this CL in the
blame
> list..

How did this CL land in the first place? There are tons of broken try jobs with
it, and it caused test breakage on the main waterfall like
https://build.chromium.org/p/chromium.gpu/builders/Win7%20Release%20%28NVIDIA...
.

[Michael Achenbach, 2016-11-18 05:56:39]

On 2016/11/17 21:44:08, Ken Russell wrote:
> On 2016/11/17 16:30:48, vogelheim wrote:
> > A revert of this CL (patchset #2 id:20001) has been created in
> > https://codereview.chromium.org/2512473003/ by
mailto:vogelheim@chromium.org.
> > 
> > The reason for reverting is: There's several breakages with this CL in the
> blame
> > list..
> 
> How did this CL land in the first place? There are tons of broken try jobs
with
> it, and it caused test breakage on the main waterfall like
>
https://build.chromium.org/p/chromium.gpu/builders/Win7%20Release%20%28NVIDIA...
> .

Very sorry for that. The commit message was copied manyually from the last
branch and there slipped a NOTRY=true through. Last time it was added only in
the end to overcome an infra problem on one bot.

We reverted, then removed the NOTRY=true, then tried relanding this again.

Bug2 is that this CL shouldn't cause test failures at all if everybody had
adhered V8's branch policy. In branch week V8 is supposed to stay compatible
with all chrome versions of the week, so that we can roll back to the version
we're intending to ship. Looks like someone added stuff to chrome in the
meantime that made it incompatible.

[Michael Achenbach, 2016-11-18 10:07:20]

On 2016/11/18 05:56:39, machenbach (slow) wrote:
> On 2016/11/17 21:44:08, Ken Russell wrote:
> > On 2016/11/17 16:30:48, vogelheim wrote:
> > > A revert of this CL (patchset #2 id:20001) has been created in
> > > https://codereview.chromium.org/2512473003/ by
> mailto:vogelheim@chromium.org.
> > > 
> > > The reason for reverting is: There's several breakages with this CL in the
> > blame
> > > list..
> > 
> > How did this CL land in the first place? There are tons of broken try jobs
> with
> > it, and it caused test breakage on the main waterfall like
> >
>
https://build.chromium.org/p/chromium.gpu/builders/Win7%20Release%20%28NVIDIA...
> > .
> 
> Very sorry for that. The commit message was copied manyually from the last
> branch and there slipped a NOTRY=true through. Last time it was added only in
> the end to overcome an infra problem on one bot.
> 
> We reverted, then removed the NOTRY=true, then tried relanding this again.
> 
> Bug2 is that this CL shouldn't cause test failures at all if everybody had
> adhered V8's branch policy. In branch week V8 is supposed to stay compatible
> with all chrome versions of the week, so that we can roll back to the version
> we're intending to ship. Looks like someone added stuff to chrome in the
> meantime that made it incompatible.

Abandoning this in favor of https://codereview.chromium.org/2508043003/