Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: tools/parser-shell.cc

Issue 2513563002: Remove FLAG_min_preparse_length. (Closed)
Patch Set: test262 expectations Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 v8::Utils::OpenHandle(*source_handle)); 92 v8::Utils::OpenHandle(*source_handle));
93 i::ScriptData* cached_data_impl = NULL; 93 i::ScriptData* cached_data_impl = NULL;
94 // First round of parsing (produce data to cache). 94 // First round of parsing (produce data to cache).
95 { 95 {
96 Zone zone(reinterpret_cast<i::Isolate*>(isolate)->allocator(), ZONE_NAME); 96 Zone zone(reinterpret_cast<i::Isolate*>(isolate)->allocator(), ZONE_NAME);
97 ParseInfo info(&zone, script); 97 ParseInfo info(&zone, script);
98 info.set_cached_data(&cached_data_impl); 98 info.set_cached_data(&cached_data_impl);
99 info.set_compile_options(v8::ScriptCompiler::kProduceParserCache); 99 info.set_compile_options(v8::ScriptCompiler::kProduceParserCache);
100 v8::base::ElapsedTimer timer; 100 v8::base::ElapsedTimer timer;
101 timer.Start(); 101 timer.Start();
102 // Allow lazy parsing; otherwise we won't produce cached data.
103 info.set_allow_lazy_parsing();
104 bool success = Parser::ParseStatic(&info); 102 bool success = Parser::ParseStatic(&info);
105 parse_time1 = timer.Elapsed(); 103 parse_time1 = timer.Elapsed();
106 if (!success) { 104 if (!success) {
107 fprintf(stderr, "Parsing failed\n"); 105 fprintf(stderr, "Parsing failed\n");
108 return std::make_pair(v8::base::TimeDelta(), v8::base::TimeDelta()); 106 return std::make_pair(v8::base::TimeDelta(), v8::base::TimeDelta());
109 } 107 }
110 } 108 }
111 // Second round of parsing (consume cached data). 109 // Second round of parsing (consume cached data).
112 { 110 {
113 Zone zone(reinterpret_cast<i::Isolate*>(isolate)->allocator(), ZONE_NAME); 111 Zone zone(reinterpret_cast<i::Isolate*>(isolate)->allocator(), ZONE_NAME);
114 ParseInfo info(&zone, script); 112 ParseInfo info(&zone, script);
115 info.set_cached_data(&cached_data_impl); 113 info.set_cached_data(&cached_data_impl);
116 info.set_compile_options(v8::ScriptCompiler::kConsumeParserCache); 114 info.set_compile_options(v8::ScriptCompiler::kConsumeParserCache);
117 v8::base::ElapsedTimer timer; 115 v8::base::ElapsedTimer timer;
118 timer.Start(); 116 timer.Start();
119 // Allow lazy parsing; otherwise cached data won't help.
120 info.set_allow_lazy_parsing();
121 bool success = Parser::ParseStatic(&info); 117 bool success = Parser::ParseStatic(&info);
122 parse_time2 = timer.Elapsed(); 118 parse_time2 = timer.Elapsed();
123 if (!success) { 119 if (!success) {
124 fprintf(stderr, "Parsing failed\n"); 120 fprintf(stderr, "Parsing failed\n");
125 return std::make_pair(v8::base::TimeDelta(), v8::base::TimeDelta()); 121 return std::make_pair(v8::base::TimeDelta(), v8::base::TimeDelta());
126 } 122 }
127 } 123 }
128 return std::make_pair(parse_time1, parse_time2); 124 return std::make_pair(parse_time1, parse_time2);
129 } 125 }
130 126
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 printf("%s(SecondParseRunTime): %.f ms\n", benchmark.c_str(), 180 printf("%s(SecondParseRunTime): %.f ms\n", benchmark.c_str(),
185 second_parse_total); 181 second_parse_total);
186 } 182 }
187 } 183 }
188 v8::V8::Dispose(); 184 v8::V8::Dispose();
189 v8::V8::ShutdownPlatform(); 185 v8::V8::ShutdownPlatform();
190 delete platform; 186 delete platform;
191 delete create_params.array_buffer_allocator; 187 delete create_params.array_buffer_allocator;
192 return 0; 188 return 0;
193 } 189 }
OLDNEW
« no previous file with comments | « test/webkit/fast/js/parser-syntax-check-expected.txt ('k') | tools/testrunner/local/variants.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698