Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2513563002: Remove FLAG_min_preparse_length. (Closed)

Created:
4 years, 1 month ago by marja
Modified:
4 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove FLAG_min_preparse_length. It originates from the era where we used to run a separate preparse step before parsing and store the function data. Now the usage of preparser is something completely different, so this flag doesn't make sense any more. In addition, this way we get more test coverage for preparser (for small scripts). BUG= Committed: https://crrev.com/4a5b7e32c4f687bd481fc6d58adf7c2c695d2466 Cr-Commit-Position: refs/heads/master@{#41110}

Patch Set 1 #

Patch Set 2 : cleaning up set_allow_lazy_parsing too #

Patch Set 3 : test fixes #

Patch Set 4 : more test fixes #

Patch Set 5 : rebased #

Patch Set 6 : still more #

Patch Set 7 : test262 expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -88 lines) Patch
M src/flag-definitions.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M src/parsing/parse-info.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/parsing/parse-info.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 4 chunks +0 lines, -4 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 3 4 11 chunks +7 lines, -9 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/message/for-loop-invalid-lhs.js View 1 chunk +0 lines, -4 lines 0 comments Download
M test/message/for-loop-invalid-lhs.out View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/bugs/bug-2728.js View 1 2 3 4 5 1 chunk +21 lines, -0 lines 0 comments Download
M test/mjsunit/eagerly-parsed-lazily-compiled-functions.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/arrow-rest-params-lazy-parsing.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/block-scoping-top-level.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/es6/block-scoping-top-level-sloppy.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/classes-lazy-parsing.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/destructuring-assignment-lazy.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/regress/regress-4400.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/regress/regress-594084.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/lazy-inner-functions.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/modules-preparse.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/preparse-toplevel-strict-eval.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/regress-3456.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/regress-604044.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-517592.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-580934.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-648740.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-659915a.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-659915b.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test262/test262.status View 1 2 3 4 5 6 1 chunk +10 lines, -1 line 0 comments Download
M test/webkit/fast/js/kde/parse.js View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M test/webkit/fast/js/kde/parse-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M test/webkit/fast/js/parser-syntax-check.js View 1 2 3 3 chunks +0 lines, -6 lines 0 comments Download
M test/webkit/fast/js/parser-syntax-check-expected.txt View 1 2 3 3 chunks +0 lines, -10 lines 0 comments Download
M tools/parser-shell.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M tools/testrunner/local/variants.py View 1 2 3 4 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 28 (23 generated)
Toon Verwaest
Yay! lgtm
4 years, 1 month ago (2016-11-17 10:15:03 UTC) #4
Toon Verwaest
lgtm
4 years, 1 month ago (2016-11-18 14:02:50 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513563002/120001
4 years, 1 month ago (2016-11-18 14:03:26 UTC) #25
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 1 month ago (2016-11-18 14:06:33 UTC) #26
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 14:07:01 UTC) #28
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/4a5b7e32c4f687bd481fc6d58adf7c2c695d2466
Cr-Commit-Position: refs/heads/master@{#41110}

Powered by Google App Engine
This is Rietveld 408576698