Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2513543003:
Don't hardcode copy of root cert in chromeos/login/test/https_forwarder.cc. (Closed)
DescriptionDon't hardcode copy of root cert in chromeos/login/test/https_forwarder.cc.
Also use ScopedTestRoot instead of TestRootCerts::Add.
BUG=651965
Committed: https://crrev.com/fff06067760baa7539a6b4dfd6bb9e203e3c23fe
Cr-Commit-Position: refs/heads/master@{#434795}
Patch Set 1 #
Total comments: 4
Patch Set 2 : review changes #
Messages
Total messages: 24 (14 generated)
The CQ bit was checked by mattm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mattm@chromium.org changed reviewers: + achuith@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ping
So sorry for the delay! https://codereview.chromium.org/2513543003/diff/1/chrome/browser/chromeos/log... File chrome/browser/chromeos/login/test/https_forwarder.cc (right): https://codereview.chromium.org/2513543003/diff/1/chrome/browser/chromeos/log... chrome/browser/chromeos/login/test/https_forwarder.cc:111: // Mark the root certificate used by minica.py as trusted. This will be used Please update this comment. https://codereview.chromium.org/2513543003/diff/1/chrome/browser/chromeos/log... File chrome/browser/chromeos/login/test/https_forwarder.h (right): https://codereview.chromium.org/2513543003/diff/1/chrome/browser/chromeos/log... chrome/browser/chromeos/login/test/https_forwarder.h:17: } // namespace net drop comment
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by mattm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2513543003/diff/1/chrome/browser/chromeos/log... File chrome/browser/chromeos/login/test/https_forwarder.cc (right): https://codereview.chromium.org/2513543003/diff/1/chrome/browser/chromeos/log... chrome/browser/chromeos/login/test/https_forwarder.cc:111: // Mark the root certificate used by minica.py as trusted. This will be used On 2016/11/28 09:09:49, achuithb wrote: > Please update this comment. Done. https://codereview.chromium.org/2513543003/diff/1/chrome/browser/chromeos/log... File chrome/browser/chromeos/login/test/https_forwarder.h (right): https://codereview.chromium.org/2513543003/diff/1/chrome/browser/chromeos/log... chrome/browser/chromeos/login/test/https_forwarder.h:17: } // namespace net On 2016/11/28 09:09:49, achuithb wrote: > drop comment Done.
Is this part of a larger cleanup? Is there no bug that can be referenced? lgtm
On 2016/11/28 22:38:23, achuithb wrote: > Is this part of a larger cleanup? Is there no bug that can be referenced? > > lgtm It came up due to https://codereview.chromium.org/2388393002/ which required regenerating the root cert. I guess I can use the same bug number here to show the connection..
On 2016/11/28 22:45:34, mattm wrote: > On 2016/11/28 22:38:23, achuithb wrote: > > Is this part of a larger cleanup? Is there no bug that can be referenced? > > > > lgtm > > It came up due to https://codereview.chromium.org/2388393002/ which required > regenerating the root cert. I guess I can use the same bug number here to show > the connection.. That sounds good
Description was changed from ========== Don't hardcode copy of root cert in chromeos/login/test/https_forwarder.cc. Also use ScopedTestRoot instead of TestRootCerts::Add. BUG=none ========== to ========== Don't hardcode copy of root cert in chromeos/login/test/https_forwarder.cc. Also use ScopedTestRoot instead of TestRootCerts::Add. BUG=651965 ==========
The CQ bit was unchecked by mattm@chromium.org
The CQ bit was checked by mattm@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480375771221860,
"parent_rev": "1d159096aa25288dbe85fb00cd30bdcf12ff11df", "commit_rev":
"bd60c84ca0fb5daf9b09f21c50e63473f0553900"}
Message was sent while issue was closed.
Description was changed from ========== Don't hardcode copy of root cert in chromeos/login/test/https_forwarder.cc. Also use ScopedTestRoot instead of TestRootCerts::Add. BUG=651965 ========== to ========== Don't hardcode copy of root cert in chromeos/login/test/https_forwarder.cc. Also use ScopedTestRoot instead of TestRootCerts::Add. BUG=651965 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Don't hardcode copy of root cert in chromeos/login/test/https_forwarder.cc. Also use ScopedTestRoot instead of TestRootCerts::Add. BUG=651965 ========== to ========== Don't hardcode copy of root cert in chromeos/login/test/https_forwarder.cc. Also use ScopedTestRoot instead of TestRootCerts::Add. BUG=651965 Committed: https://crrev.com/fff06067760baa7539a6b4dfd6bb9e203e3c23fe Cr-Commit-Position: refs/heads/master@{#434795} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/fff06067760baa7539a6b4dfd6bb9e203e3c23fe Cr-Commit-Position: refs/heads/master@{#434795} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
