Files App: Update the context menu when installed app is changed.

Files App: Update the context menu and open button when installed app
is changed.

This CL is based on https://codereview.chromium.org/2487623002.

BUG=620577
TEST=manually tested using minnie:
1. Select a PDF file on Files App.
2. Install Kindle.
3. Confirm "more action..." appears on the context menu and Open
button's UI changes to be able to open Kindle.
4. Uninstall Kindle.
5. Confirm "more action..." no longer appears and Open button doesn't
show Kindle up anymore.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/db598a3cac95e914bf357132548bffeec16e6490
Cr-Commit-Position: refs/heads/master@{#436895}

[oka, 2016-11-17 01:32:18]

Description was changed from

==========
Files App: Update the context menu when installed app is changed.

BUG=620577
==========

to

==========
Files App: Update the context menu when installed app is changed.

BUG=620577
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2016-11-17 01:32:45]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 01:35:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 03:38:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 03:38:45]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_compile_dbg on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_cronet on master.tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_android on master.tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)

[oka, 2016-11-17 05:32:17]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 05:33:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 08:32:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 08:33:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oka, 2016-11-21 07:14:47]

Description was changed from

==========
Files App: Update the context menu when installed app is changed.

BUG=620577
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files App: Update the context menu when installed app is changed.

TEST=manually tested using minnie:
1. Select a PDF file on Files App.
2. Install Kindle.
3. Confirm "more action..." appears on the context menu and also Open button's
UI changes to be able to select Kindle.

BUG=620577
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2016-11-21 07:15:35]

Description was changed from

==========
Files App: Update the context menu when installed app is changed.

TEST=manually tested using minnie:
1. Select a PDF file on Files App.
2. Install Kindle.
3. Confirm "more action..." appears on the context menu and also Open button's
UI changes to be able to select Kindle.

BUG=620577
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files App: Update the context menu when installed app is changed.

TEST=manually tested using minnie:
1. Select a PDF file on Files App.
2. Install Kindle.
3. Confirm "more action..." appears on the context menu and Open button's
UI changes to be able to open Kindle.

BUG=620577
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2016-11-21 07:16:40]

Description was changed from

==========
Files App: Update the context menu when installed app is changed.

TEST=manually tested using minnie:
1. Select a PDF file on Files App.
2. Install Kindle.
3. Confirm "more action..." appears on the context menu and Open button's
UI changes to be able to open Kindle.

BUG=620577
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files App: Update the context menu when installed app is changed.

TEST=manually tested using minnie:
1. Select a PDF file on Files App.
2. Install Kindle.
3. Confirm "more action..." appears on the context menu and Open
button's UI changes to be able to open Kindle.

BUG=620577
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2016-11-21 07:29:16]

Description was changed from

==========
Files App: Update the context menu when installed app is changed.

TEST=manually tested using minnie:
1. Select a PDF file on Files App.
2. Install Kindle.
3. Confirm "more action..." appears on the context menu and Open
button's UI changes to be able to open Kindle.

BUG=620577
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files App: Update the context menu when installed app is changed.

TEST=manually tested using minnie:
1. Select a PDF file on Files App.
2. Install Kindle.
3. Confirm "more action..." appears on the context menu and Open
button's UI changes to be able to open Kindle.

BUG=620577
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2016-11-21 07:33:02]

Description was changed from

==========
Files App: Update the context menu when installed app is changed.

TEST=manually tested using minnie:
1. Select a PDF file on Files App.
2. Install Kindle.
3. Confirm "more action..." appears on the context menu and Open
button's UI changes to be able to open Kindle.

BUG=620577
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files App: Update the context menu and open button when installed app
is changed.

TEST=manually tested using minnie:
1. Select a PDF file on Files App.
2. Install Kindle.
3. Confirm "more action..." appears on the context menu and Open
button's UI changes to be able to open Kindle.

BUG=620577
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2016-11-21 07:34:02]

Description was changed from

==========
Files App: Update the context menu and open button when installed app
is changed.

TEST=manually tested using minnie:
1. Select a PDF file on Files App.
2. Install Kindle.
3. Confirm "more action..." appears on the context menu and Open
button's UI changes to be able to open Kindle.

BUG=620577
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files App: Update the context menu and open button when installed app
is changed.

BUG=620577
TEST=manually tested using minnie:
1. Select a PDF file on Files App.
2. Install Kindle.
3. Confirm "more action..." appears on the context menu and Open
button's UI changes to be able to open Kindle.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2016-11-21 08:25:02]

Description was changed from

==========
Files App: Update the context menu and open button when installed app
is changed.

BUG=620577
TEST=manually tested using minnie:
1. Select a PDF file on Files App.
2. Install Kindle.
3. Confirm "more action..." appears on the context menu and Open
button's UI changes to be able to open Kindle.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files App: Update the context menu and open button when installed app
is changed.

This CL is based on https://codereview.chromium.org/2487623002.

BUG=620577
TEST=manually tested using minnie:
1. Select a PDF file on Files App.
2. Install Kindle.
3. Confirm "more action..." appears on the context menu and Open
button's UI changes to be able to open Kindle.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2016-11-21 08:25:02]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[fukino, 2016-11-21 08:57:50]

Please check the failing test.

https://codereview.chromium.org/2513493002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/task_controller.js (right):

https://codereview.chromium.org/2513493002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/task_controller.js:102:
this.onSelectionChangeThrottled_.bind(this));
Direct wiring to onSelectionChangeThrottled_ looks a bit strange to me.
How about extract a logic to update the context menu and dropdown menu, and call
it from onSelectionChangeThrottled_ and here?

[oka, 2016-11-21 09:14:47]

https://codereview.chromium.org/2513493002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/task_controller.js (right):

https://codereview.chromium.org/2513493002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/task_controller.js:102:
this.onSelectionChangeThrottled_.bind(this));
On 2016/11/21 08:57:50, fukino wrote:
> Direct wiring to onSelectionChangeThrottled_ looks a bit strange to me.
> How about extract a logic to update the context menu and dropdown menu, and
call
> it from onSelectionChangeThrottled_ and here?

That's exactly what onSelectionChangeThrottled_ does. How about just renaming
onSelectionChangeThrottled_?

[fukino, 2016-11-21 09:27:29]

https://codereview.chromium.org/2513493002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/task_controller.js (right):

https://codereview.chromium.org/2513493002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/task_controller.js:102:
this.onSelectionChangeThrottled_.bind(this));
On 2016/11/21 09:14:47, oka wrote:
> On 2016/11/21 08:57:50, fukino wrote:
> > Direct wiring to onSelectionChangeThrottled_ looks a bit strange to me.
> > How about extract a logic to update the context menu and dropdown menu, and
> call
> > it from onSelectionChangeThrottled_ and here?
> 
> That's exactly what onSelectionChangeThrottled_ does. How about just renaming
> onSelectionChangeThrottled_?

sgtm

[oka, 2016-11-24 14:53:44]

On 2016/11/21 09:27:29, fukino wrote:
>
https://codereview.chromium.org/2513493002/diff/1/ui/file_manager/file_manage...
> File ui/file_manager/file_manager/foreground/js/task_controller.js (right):
> 
>
https://codereview.chromium.org/2513493002/diff/1/ui/file_manager/file_manage...
> ui/file_manager/file_manager/foreground/js/task_controller.js:102:
> this.onSelectionChangeThrottled_.bind(this));
> On 2016/11/21 09:14:47, oka wrote:
> > On 2016/11/21 08:57:50, fukino wrote:
> > > Direct wiring to onSelectionChangeThrottled_ looks a bit strange to me.
> > > How about extract a logic to update the context menu and dropdown menu,
and
> > call
> > > it from onSelectionChangeThrottled_ and here?
> > 
> > That's exactly what onSelectionChangeThrottled_ does. How about just
renaming
> > onSelectionChangeThrottled_?
> 
> sgtm

Done.

[fukino, 2016-11-25 05:05:01]

lgtm

[oka, 2016-11-25 11:54:06]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-25 11:54:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2016-11-25 12:01:15]

Description was changed from

==========
Files App: Update the context menu and open button when installed app
is changed.

This CL is based on https://codereview.chromium.org/2487623002.

BUG=620577
TEST=manually tested using minnie:
1. Select a PDF file on Files App.
2. Install Kindle.
3. Confirm "more action..." appears on the context menu and Open
button's UI changes to be able to open Kindle.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files App: Update the context menu and open button when installed app
is changed.

This CL is based on https://codereview.chromium.org/2487623002.

BUG=620577
TEST=manually tested using minnie:
1. Select a PDF file on Files App.
2. Install Kindle.
3. Confirm "more action..." appears on the context menu and Open
button's UI changes to be able to open Kindle.
4. Uninstall Kindle.
5. Confirm "more action..." no longer appears and Open button doesn't
show Kindle up anymore.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-11-25 13:09:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 13:09:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oka, 2016-12-02 06:45:35]

The CQ bit was checked by oka@chromium.org

[oka, 2016-12-02 06:45:35]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2513493002/#ps60001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-12-02 06:45:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2016-12-02 07:32:04]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 07:32:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 08:48:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 08:48:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oka, 2016-12-07 07:18:30]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 07:18:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2016-12-07 07:19:05]

PTALA. Modified task_controller_unittest.js

[fukino, 2016-12-07 08:02:41]

still lgtm

[oka, 2016-12-07 08:38:43]

The CQ bit was unchecked by oka@chromium.org

[oka, 2016-12-07 08:38:43]

The CQ bit was checked by oka@chromium.org

[commit-bot: I haz the power, 2016-12-07 08:39:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2016-12-07 08:39:04]

The CQ bit was checked by oka@chromium.org

[commit-bot: I haz the power, 2016-12-07 08:39:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 09:07:05]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1481099944264920,
"parent_rev": "02b18ee4f73d880e9434a573bdc2b0b502aeedfa", "commit_rev":
"983c26aac198c8cd7f2444cfb59938f065f51e02"}

[commit-bot: I haz the power, 2016-12-07 09:07:35]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-12-07 09:10:41]

Description was changed from

==========
Files App: Update the context menu and open button when installed app
is changed.

This CL is based on https://codereview.chromium.org/2487623002.

BUG=620577
TEST=manually tested using minnie:
1. Select a PDF file on Files App.
2. Install Kindle.
3. Confirm "more action..." appears on the context menu and Open
button's UI changes to be able to open Kindle.
4. Uninstall Kindle.
5. Confirm "more action..." no longer appears and Open button doesn't
show Kindle up anymore.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files App: Update the context menu and open button when installed app
is changed.

This CL is based on https://codereview.chromium.org/2487623002.

BUG=620577
TEST=manually tested using minnie:
1. Select a PDF file on Files App.
2. Install Kindle.
3. Confirm "more action..." appears on the context menu and Open
button's UI changes to be able to open Kindle.
4. Uninstall Kindle.
5. Confirm "more action..." no longer appears and Open button doesn't
show Kindle up anymore.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/db598a3cac95e914bf357132548bffeec16e6490
Cr-Commit-Position: refs/heads/master@{#436895}
==========

[commit-bot: I haz the power, 2016-12-07 09:10:42]

Patchset 7 (id:??) landed as
https://crrev.com/db598a3cac95e914bf357132548bffeec16e6490
Cr-Commit-Position: refs/heads/master@{#436895}