Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 2513473007: Minor style changes to HarfBuzzShaper to improve readability (Closed)

Created:
4 years, 1 month ago by eae
Modified:
4 years, 1 month ago
Reviewers:
szager1, Matt Giuca
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor style changes to HarfBuzzShaper to improve readability TBR=szager@chromium.org Committed: https://crrev.com/95b18a0f83f57c597c435e09b4081d995e0defe0 Cr-Commit-Position: refs/heads/master@{#433265}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -37 lines) Patch
M third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 8 chunks +30 lines, -37 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513473007/1
4 years, 1 month ago (2016-11-18 17:26:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 19:35:41 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/95b18a0f83f57c597c435e09b4081d995e0defe0 Cr-Commit-Position: refs/heads/master@{#433265}
4 years, 1 month ago (2016-11-18 19:37:17 UTC) #5
Matt Giuca
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2517023002/ by mgiuca@chromium.org. ...
4 years, 1 month ago (2016-11-21 00:53:25 UTC) #6
Matt Giuca
4 years, 1 month ago (2016-11-21 04:20:46 UTC) #9
Sorry, this revert appears to have not fixed the bug (https://crbug.com/667147).

Please re-land at your convenience.

Powered by Google App Engine
This is Rietveld 408576698