[Android NTP] Move suggestion sections into a separate node.

chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.ntp.cards;
 
 import android.content.Context;
 import android.support.annotation.DrawableRes;
 import android.support.annotation.Nullable;
 import android.support.annotation.StringRes;
@@ skipping 24 matching lines @@
      * Whether the user has seen the promo and dismissed it at some point. When this is set,
      * the promo will never be shown.
      */
     private boolean mDismissed;
 
     private final ImpressionTracker mImpressionTracker = new ImpressionTracker(null, this);
 
     @Nullable
     private final SigninObserver mObserver;
 
-    public SignInPromo(NodeParent parent) {
+    public SignInPromo(NodeParent parent, NewTabPageManager newTabPageManager) {
         super(parent);
         mDismissed = ChromePreferenceManager.getInstance(ContextUtils.getApplicationContext())
                              .getNewTabPageSigninPromoDismissed();
 
-        final SigninManager signinManager = SigninManager.get(ContextUtils.getApplicationContext());
-        mObserver = mDismissed ? null : new SigninObserver(signinManager);
+        SigninManager signinManager = SigninManager.get(ContextUtils.getApplicationContext());
+        if (mDismissed) {
+            mObserver = null;
+        } else {
+            mObserver = new SigninObserver(signinManager);
+            newTabPageManager.addDestructionObserver(mObserver);
+        }
+    }
+
+    @Override
+    public void init() {
+        super.init();
+        SigninManager signinManager = SigninManager.get(ContextUtils.getApplicationContext());
         setVisible(signinManager.isSignInAllowed() && !signinManager.isSignedInOnNative());
     }
 
     @Override
     @ItemViewType
     public int getItemViewType() {
         return ItemViewType.PROMO;
     }
 
     /**
      * @returns a {@link DestructionObserver} observer that updates the visibility of the signin
      * promo and unregisters itself when the New Tab Page is destroyed.
      */
     @Nullable
     public DestructionObserver getObserver() {

[dgn, 2016/12/13 14:54:47]

now unused?

         return mObserver;
     }
 
     @Override
     public void onBindViewHolder(NewTabPageViewHolder holder) {
         assert holder instanceof StatusCardViewHolder;
         ((StatusCardViewHolder) holder).onBindViewHolder(this);
         mImpressionTracker.reset(mImpressionTracker.wasTriggered() ? null : holder.itemView);
     }
 
@@ skipping 129 matching lines @@
                 getParams().topMargin = 0;
             }
         }
 
         @Override
         public boolean isDismissable() {
             return true;
         }
     }
 }