Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 251343003: Checked validity of status_widget before calling IsActive method. (Closed)

Created:
6 years, 8 months ago by Shrikant Kelkar
Modified:
6 years, 8 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, ananta
Visibility:
Public.

Description

Checked validity of status_widget before calling IsActive method. Rest of the code seem to suggest that we always check validity of status_area_widget() pointer before calling method on it. Also a specific comment in the code "status_area_widget() may be NULL during the shutdown." seems to suggest status_area_widget being NULL is expected. shelf_ could have been a possible culprit here, but before we reach this particular statment, we have already called methods on it, so possibility of status_area_widget() being culprit is more. This bug doesn't repro on my machine so have to go with guess work. BUG=365631 R=skuhne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ash/shelf/shelf_layout_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Shrikant Kelkar
6 years, 8 months ago (2014-04-23 23:15:15 UTC) #1
Mr4D (OOO till 08-26)
lgtm
6 years, 8 months ago (2014-04-23 23:18:51 UTC) #2
Shrikant Kelkar
The CQ bit was checked by shrikant@chromium.org
6 years, 8 months ago (2014-04-23 23:20:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shrikant@chromium.org/251343003/1
6 years, 8 months ago (2014-04-23 23:21:09 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 00:09:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-24 00:09:25 UTC) #6
Shrikant Kelkar
6 years, 8 months ago (2014-04-24 00:26:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r265790 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698