third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py - Issue 2513423003: DevTools: Convert inspector-unit tests to use reusable test harness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 2513423003: DevTools: Convert inspector-unit tests to use reusable test harness (Closed)

Patch Set: clean diff Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/inspector-unit/resources/inspector-unit-test-shell.html ('K') | « third_party/WebKit/LayoutTests/http/tests/inspector-unit/trie-spec-expected.txt ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

index c986ba7614b3a5811281018af44422403d34993e..a6916ee79df6f15f97962d6e31ede57080680d12 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

@@ -781,7 +781,8 @@ class Port(object):

def _has_supported_extension(filesystem, filename):

"""Return true if filename is one of the file extensions we want to run a test on."""

extension = filesystem.splitext(filename)[1]

- return extension in Port._supported_file_extensions

+ is_js_test = filename.endswith('-spec.js')

+ return extension in Port._supported_file_extensions or is_js_test

def is_test_file(self, filesystem, dirname, filename):

match = re.search(r'[/\\]imported[/\\]wpt([/\\].*)?$', dirname)