Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: components/test_runner/test_runner.h

Issue 2513423003: DevTools: Convert inspector-unit tests to use reusable test harness (Closed)
Patch Set: clean diff Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/test_runner.h
diff --git a/components/test_runner/test_runner.h b/components/test_runner/test_runner.h
index 5f93c52fb356ef0063d0ceff6d96c96a3ba03e54..bcdc49ba0980f9d5e9978a5e63310479d317446d 100644
--- a/components/test_runner/test_runner.h
+++ b/components/test_runner/test_runner.h
@@ -21,6 +21,7 @@
#include "media/midi/midi_service.mojom.h"
#include "third_party/WebKit/public/platform/WebEffectiveConnectionType.h"
#include "third_party/WebKit/public/platform/WebImage.h"
+#include "third_party/WebKit/public/platform/WebURL.h"
#include "v8/include/v8.h"
class GURL;
@@ -87,6 +88,11 @@ class TestRunner : public WebTestRunner {
bool UseMockTheme() const { return use_mock_theme_; }
+ // By default, tests end when page load is complete. These methods are used
+ // to delay the completion of the test until notifyDone is called.
+ void NotifyDone();
+ void WaitUntilDone();
+
// WebTestRunner implementation.
bool ShouldGeneratePixelResults() override;
bool ShouldDumpAsAudio() const override;
@@ -120,6 +126,7 @@ class TestRunner : public WebTestRunner {
void ShowDevTools(const std::string& settings,
const std::string& frontend_url);
void ClearDevToolsLocalStorage();
+ void LoadURLForMainFrame(const blink::WebURL& url);
void setShouldDumpAsText(bool);
void setShouldDumpAsMarkup(bool);
void setCustomTextOutput(const std::string& text);
@@ -221,11 +228,6 @@ class TestRunner : public WebTestRunner {
///////////////////////////////////////////////////////////////////////////
// Methods dealing with the test logic
- // By default, tests end when page load is complete. These methods are used
- // to delay the completion of the test until notifyDone is called.
- void NotifyDone();
- void WaitUntilDone();
-
// Methods for adding actions to the work queue. Used in conjunction with
// waitUntilDone/notifyDone above.
void QueueBackNavigation(int how_far_back);

Powered by Google App Engine
This is Rietveld 408576698