third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js - Issue 2513423003: DevTools: Convert inspector-unit tests to use reusable test harness

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js

Issue 2513423003: DevTools: Convert inspector-unit tests to use reusable test harness (Closed)

Patch Set: Moved type definition out of externs Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.html ('k') | third_party/WebKit/LayoutTests/http/tests/inspector-unit/inspector-unit-test.js » ('j') | third_party/WebKit/Source/devtools/front_end/test_runner/TestRunner.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.html b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js

similarity index 70%

rename from third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.html

rename to third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js

index 8c79670a083877f5ae2770aa9e2f9235eeb77c81..3d4a7ada7e1bf97a664c11dc21d0aa729fcc1917 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector-unit/filtered-item-selection-dialog-filtering.js

@@ -1,12 +1,7 @@

-<html>

-<head>

-<base href="/inspector-debug/"></base>

-<script src="/inspector-debug/Runtime.js"></script>

-<script src="/inspector-unit/inspector-unit-test.js"></script>

-<script>

-UnitTest.addDependency("ui_lazy");

-function test()

+TestRunner.loadLazyModules(["ui_lazy"]).then(test);

+function test() {

+ TestRunner.addResult("Check to see that FilteredItemSelectionDialog uses proper regex to filter results.");

var overridenInput = [];

var overrideShowMatchingItems = true;

var history = [];

@@ -22,7 +17,7 @@ function test()

itemCount() { return overridenInput.length; }

selectItem(itemIndex, promptValue)

{

- UnitTest.addResult("Selected item index: " + itemIndex);

+ TestRunner.addResult("Selected item index: " + itemIndex);

}

shouldShowMatchingItems () { return overrideShowMatchingItems; }

};

@@ -34,34 +29,34 @@ function test()

overridenInput = input;

overrideShowMatchingItems = !hideMatchingItems;

- UnitTest.addResult("Input:" + JSON.stringify(input));

+ TestRunner.addResult("Input:" + JSON.stringify(input));

var filteredSelectionDialog = new UI.FilteredListWidget(delegate);

filteredSelectionDialog.showAsDialog();

- var promise = UnitTest.addSniffer(filteredSelectionDialog, "_itemsFilteredForTest").then(accept);

+ var promise = TestRunner.addSniffer(filteredSelectionDialog, "_itemsFilteredForTest").then(accept);

filteredSelectionDialog.setQuery(query);

filteredSelectionDialog._updateAfterItemsLoaded();

return promise;

function dump()

{

- UnitTest.addResult("Query:" + JSON.stringify(filteredSelectionDialog._value()));

+ TestRunner.addResult("Query:" + JSON.stringify(filteredSelectionDialog._value()));

var items = filteredSelectionDialog._filteredItems;

var output = [];

for (var i = 0; i < items.length; ++i)

output.push(delegate.itemKeyAt(items[i]));

- UnitTest.addResult("Output:" + JSON.stringify(output));

+ TestRunner.addResult("Output:" + JSON.stringify(output));

}

function accept()

{

dump();

- filteredSelectionDialog._onEnter(UnitTest.createKeyEvent("Enter"));

- UnitTest.addResult("History:" + JSON.stringify(history));

+ filteredSelectionDialog._onEnter(TestRunner.createKeyEvent("Enter"));

+ TestRunner.addResult("History:" + JSON.stringify(history));

}

- UnitTest.runTests([

+ TestRunner.runTests([

function emptyQueryMatchesEverything()

{

return checkQuery("", ["a", "bc"]);

@@ -98,12 +93,3 @@ function test()

}

]);

}

-</script>

-</head>

-<body>

-<p>Check to see that FilteredItemSelectionDialog uses proper regex to filter results.</p>

-</body>

-</html>