DevTools: Convert inspector-unit tests to use reusable test harness

third_party/WebKit/LayoutTests/http/tests/inspector-unit/inspector-unit-test-helper.js

 var UnitTest = {};
-(function()
-{
-    var lazyModules = [];
+var startTest;
+(function() {
     var oldLoadResourcePromise = Runtime.loadResourcePromise;
     Runtime.loadResourcePromise = function(url)
     {
         if (url.startsWith("/"))
             return oldLoadResourcePromise(url);
 
         if (!url.startsWith("http://"))
             return oldLoadResourcePromise("/inspector-debug/" + url);
 
         var parsedURL = new URL(url, location.href);
-        var parsedLocation = new URL(location.href);
 
         // hosted devtools is confused.
         parsedURL.pathname = parsedURL.pathname.replace('/inspector-unit/', '/inspector-debug/');
         return oldLoadResourcePromise(parsedURL.toString());
-    }
+    };
 
     if (window.testRunner) {
         testRunner.dumpAsText();
         testRunner.waitUntilDone();
     }
 
     var results = [];
     UnitTest.completeTest = function()
     {
         if (!window.testRunner) {
@@ skipping 68 matching lines @@
                     resolve.apply(this, arguments);
                 } catch (e) {
                     reject("Exception in overriden method '" + methodName + "': " + e);
                     UnitTest.completeTest();
                 }
                 return result;
             };
         });
     };
 
-    UnitTest.addDependency = function(lazyModule)
-    {
-        lazyModules.push(lazyModule);
+    UnitTest.loadLazyModules = function (lazyModules) {
+        return Promise.all(lazyModules.map(lazyModule => window.runtime.loadModulePromise(lazyModule)));
     };
 
     UnitTest.createKeyEvent = function(key, ctrlKey, altKey, shiftKey, metaKey)
     {
         return new KeyboardEvent("keydown", { key: key, bubbles: true, cancelable: true, ctrlKey: ctrlKey, altKey: altKey, shiftKey: shiftKey, metaKey: metaKey });
     };
 
     function completeTestOnError(message, source, lineno, colno, error)
     {
         UnitTest.addResult("TEST ENDED IN ERROR: " + error.stack);
@@ skipping 22 matching lines @@
 
         UI.zoomManager = new UI.ZoomManager(window, InspectorFrontendHost);
         UI.inspectorView = UI.InspectorView.instance();
         UI.ContextMenu.initialize();
         UI.ContextMenu.installHandler(document);
         UI.Tooltip.installHandler(document);
 
         var rootView = new UI.RootView();
         UI.inspectorView.show(rootView.element);
         rootView.attachToDocument(document);
-        Promise.all(lazyModules.map(lazyModule => window.runtime.loadModulePromise(lazyModule))).then(test);
+        executeTestScript();
+    }
+
+    function executeTestScript() {
+        fetch(`/inspector-unit/${Runtime.queryParam('test')}`)
+            .then((data) => data.text())

[dgozman, 2016/11/22 21:59:05]

Let's not .then() synchronous actions.

[chenwilliam, 2016/11/23 00:27:41]

The text() method on the Response object from a fetch returns a promise.

https://developer.mozilla.org/en-US/docs/Web/API/Body/text

+            .then((testScript) => eval(testScript))

[dgozman, 2016/11/22 21:59:05]

Let's wrap the source in closure to improve isolation between tests for the
future.

[chenwilliam, 2016/11/23 00:27:41]

Done.

+            .catch((error) => {
+                UnitTest.addResult(`Unable to execute test script because of error: ${error}`);
+                UnitTest.completeTest();
+            });
     }
 })();