DevTools: Convert inspector-unit tests to use reusable test harness

third_party/WebKit/LayoutTests/http/tests/inspector-unit/inspector-unit-test.js

 var UnitTest = {};
-(function()
-{
+var startTest;
+(function() {
     var lazyModules = [];
     var oldLoadResourcePromise = Runtime.loadResourcePromise;
     Runtime.loadResourcePromise = function(url)
     {
         if (url.startsWith("/"))
             return oldLoadResourcePromise(url);
 
         if (!url.startsWith("http://"))
             return oldLoadResourcePromise("/inspector-debug/" + url);
 
         var parsedURL = new URL(url, location.href);
         var parsedLocation = new URL(location.href);
 
+        parsedURL.pathname = parsedURL.pathname.replace('/resources/', '/');
         // hosted devtools is confused.
         parsedURL.pathname = parsedURL.pathname.replace('/inspector-unit/', '/inspector-debug/');
         return oldLoadResourcePromise(parsedURL.toString());
-    }
+    };
 
     if (window.testRunner) {
         testRunner.dumpAsText();
         testRunner.waitUntilDone();
     }
 
     var results = [];
     UnitTest.completeTest = function()
     {
         if (!window.testRunner) {
@@ skipping 85 matching lines @@
         return new KeyboardEvent("keydown", { key: key, bubbles: true, cancelable: true, ctrlKey: ctrlKey, altKey: altKey, shiftKey: shiftKey, metaKey: metaKey });
     };
 
     function completeTestOnError(message, source, lineno, colno, error)
     {
         UnitTest.addResult("TEST ENDED IN ERROR: " + error.stack);
         UnitTest.completeTest();
     }
     window.onerror = completeTestOnError;
 
-    Runtime.startApplication("/inspector-unit/inspector-unit-test").then(runTest);
+    startTest = function (test) {
+        Runtime.startApplication("/inspector-unit/inspector-unit-test").then(() => runTest(test));

[einbinder, 2016/11/22 02:19:45]

Maybe don't force things to be wrapped in function test?

[chenwilliam, 2016/11/22 20:56:05]

Done.

+    };
 
-    function runTest()
+    function runTest(test)
     {
         var description = document.body.textContent.trim();
         if (description)
             UnitTest.addResult(description);
 
         Common.settings = new Common.Settings(new Common.SettingsStorage(
             {},
             InspectorFrontendHost.setPreference,
             InspectorFrontendHost.removePreference,
             InspectorFrontendHost.clearPreferences));
 
 
         UI.viewManager = new UI.ViewManager();
         UI.initializeUIUtils(document, Common.settings.createSetting("uiTheme", "default"));
         UI.installComponentRootStyles(document.body);
 
         UI.zoomManager = new UI.ZoomManager(window, InspectorFrontendHost);
         UI.inspectorView = UI.InspectorView.instance();
         UI.ContextMenu.initialize();
         UI.ContextMenu.installHandler(document);
         UI.Tooltip.installHandler(document);
 
         var rootView = new UI.RootView();
         UI.inspectorView.show(rootView.element);
         rootView.attachToDocument(document);
         Promise.all(lazyModules.map(lazyModule => window.runtime.loadModulePromise(lazyModule))).then(test);
     }
 })();